Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOT FOR MERGE] V4.19.0.1 patches cleanup iter11 #507

Open
wants to merge 80 commits into
base: dasharo-4.21
Choose a base branch
from

Conversation

pietrushnic
Copy link
Contributor

@pietrushnic pietrushnic commented May 16, 2024

  • reduced 20 commits in this iteration,
  • a compilation of apu2/3/4/5/6/7 was tested and passing
  • a number of different/the same object file hashes in the build directory between this branch and v4.19.0.1 remains the same 175/1237 (+8)
  • all patches were compiled one by one (git rebase --exec method) for every supported PC Engines platform on given commit
  • 3.5k SLOC change

Analyze all differences between v4.19.0.1 and iter11; if the given change is not present, then justify.

 [IGNORE] .gitlab-ci.yml                                     | 308 +++++++++
 [IGNORE] .gitlab-ci/check_hw_matrix.sh                      |  19 +
 [IGNORE] .gitlab-ci/regression.sh                           |  19 +
 [IGNORE] CHANGELOG.md                                       | 675 +++++++++++++++++++
 [IGNORE] Documentation/mainboard/index.md                   |   1 -
 [IGNORE] Documentation/mainboard/intel/icelake_rvp.md       |  40 --
 [IGNORE] Documentation/security/vboot/list_vboot.md         |  36 +-
 [IGNORE] .../intel/icelake/iceLake_coreboot_development.md  |  67 --
 [IGNORE] Documentation/soc/intel/icelake/index.md           |   7 -
 [IGNORE] Documentation/soc/intel/index.md                   |   1 -
 Makefile.inc                                       |   2 +-
 - 4.19 version is preferred
 [IGNORE] README.md                                          |   9 +-
 configs/config.pcengines_apu2                      |  47 +-
 configs/config.pcengines_apu2_vboot                |  27 +
 configs/config.pcengines_apu3                      |  47 +-
 configs/config.pcengines_apu4                      |  47 +-
 configs/config.pcengines_apu5                      |  47 +-
 configs/config.pcengines_apu6                      |  47 +-
 configs/config.pcengines_apu7                      |  36 +-
 - all config files have changed order of options, and vboot was removed as no longer supported
 payloads/Makefile.inc                              |   1 +
 - payload/external/tianocore no longer exist, it is leftover from using past code
 payloads/external/FILO/Kconfig.name                |   2 +-
 - 4.19 version is preferred
 payloads/external/GRUB2/Kconfig.name               |   4 +-
 - 4.19 version is preferred
 payloads/external/LinuxBoot/Kconfig.name           |   2 +-
 - 4.19 version is preferred
 payloads/external/SeaBIOS/Kconfig.name             |   2 +-
 - 4.19 version is preferred
 payloads/external/U-Boot/Kconfig.name              |   2 +-
 - 4.19 version is preferred
 payloads/external/depthcharge/Kconfig.name         |   2 +-
 - 4.19 version is preferred
 payloads/external/edk2/Kconfig.name                |   2 +-
 - 4.19 version is preferred
 payloads/external/tianocore/Makefile               | 163 +++++
 - 4.19 version is preferred
 src/acpi/acpigen_dsm.c                             |  23 +
 - 4.19 version is preferred
 src/arch/x86/Kconfig                               |   9 -
 - 4.19 version is preferred
 src/arch/x86/include/mode_switch.h                 |   1 -
 - 4.19 version is preferred
 src/arch/x86/include/smm.h                         |   1 -
 - 4.19 version is preferred
 src/device/pciexp_device.c                         |   2 +-
 - apu1 is not supported so ` || CONFIG(BOARD_PCENGINES_APU1` was removed
 src/drivers/intel/gma/hires_fb/gma-gfx_init.adb    |   2 +-
 - 4.19 version is preferred
 src/drivers/intel/gma/text_fb/gma-gfx_init.adb     |   2 +-
 - 4.19 version is preferred
 src/drivers/mrc_cache/mrc_cache.c                  |   2 +-
 - 4.19 version is preferred
 src/drivers/usb/acpi/chip.h                        |   6 +
 - 4.19 version is preferred
 src/drivers/usb/acpi/usb_acpi.c                    |   7 +
 - 4.19 version is preferred
 src/ec/google/chromeec/acpi/ec.asl                 |   2 +-
 - 4.19 version is preferred
 src/include/acpi/acpigen_dsm.h                     |   5 +
 - 4.19 version is preferred
 src/include/cpu/intel/cpu_ids.h                    |   2 -
 - 4.19 version is preferred
 src/include/device/pci_ids.h                       |  35 +-
 - 4.19 version is preferred
 src/mainboard/amd/birman/Kconfig                   |   6 -
 - 4.19 version is preferred
 src/mainboard/amd/birman/chromeos.fmd              |  26 +-
 - 4.19 version is preferred
 src/mainboard/amd/mayan/Kconfig                    |   6 -
 - 4.19 version is preferred
 src/mainboard/amd/mayan/chromeos.fmd               |  26 +-
 - 4.19 version is preferred
 [IGNORE] src/mainboard/google/brya/Kconfig                  |   1 -
 [IGNORE] src/mainboard/google/brya/acpi/nvpcf.asl           |   6 +-
 [IGNORE] .../google/brya/variants/brya0/overridetree.cb     |  19 +-
 [IGNORE] .../google/brya/variants/crota/memory/Makefile.inc |   1 +
 [IGNORE] .../variants/crota/memory/dram_id.generated.txt    |   3 +
 [IGNORE] .../brya/variants/crota/memory/mem_parts_used.txt  |   3 +
 [IGNORE] src/mainboard/google/brya/variants/gaelin/gpio.c   |  14 +-
 [IGNORE] .../google/brya/variants/gaelin/overridetree.cb    |  21 +-
 [IGNORE] .../google/brya/variants/marasov/overridetree.cb   |   9 +-
 [IGNORE] .../variants/drallion/include/variant/variant.h    |   2 +-
 [IGNORE] .../rex/variants/baseboard/rex/devicetree.cb       |   2 +
 [IGNORE] .../google/rex/variants/rex0/overridetree.cb       |   2 -
 [IGNORE] src/mainboard/google/skyrim/Kconfig                |   8 +
 [IGNORE] src/mainboard/google/skyrim/amdfw.cfg              |  38 ++
 [IGNORE] .../skyrim/variants/frostflow/overridetree.cb      |   6 +-
 [IGNORE] .../skyrim/variants/markarth/overridetree.cb       |   3 +
 [IGNORE] src/mainboard/intel/adlrvp/spd/Makefile.inc        |  12 +-
 [IGNORE] src/mainboard/intel/icelake_rvp/Kconfig            |  52 --
 [IGNORE] src/mainboard/intel/icelake_rvp/Kconfig.name       |   4 -
 [IGNORE] src/mainboard/intel/icelake_rvp/Makefile.inc       |  22 -
 [IGNORE] src/mainboard/intel/icelake_rvp/board_id.c         |  38 --
 [IGNORE] src/mainboard/intel/icelake_rvp/board_id.h         |  15 -
 [IGNORE] src/mainboard/intel/icelake_rvp/board_info.txt     |   6 -
 [IGNORE] src/mainboard/intel/icelake_rvp/bootblock.c        |  15 -
 [IGNORE] src/mainboard/intel/icelake_rvp/chromeos.c         |  34 -
 [IGNORE] src/mainboard/intel/icelake_rvp/chromeos.fmd       |  44 --
 [IGNORE] src/mainboard/intel/icelake_rvp/dsdt.asl           |  45 --
 [IGNORE] src/mainboard/intel/icelake_rvp/hda_verb.c         |   2 -
 [IGNORE] src/mainboard/intel/icelake_rvp/mainboard.c        |  19 -
 [IGNORE] .../intel/icelake_rvp/romstage_fsp_params.c        |  51 --
 [IGNORE] src/mainboard/intel/icelake_rvp/spd/Makefile.inc   |  12 -
 [IGNORE] src/mainboard/intel/icelake_rvp/spd/empty.spd.hex  |  32 -
 [IGNORE] .../icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.hex |  32 -
 [IGNORE] src/mainboard/intel/icelake_rvp/spd/spd.h          |  12 -
 [IGNORE] src/mainboard/intel/icelake_rvp/spd/spd_util.c     | 129 ----
 [IGNORE]  .../variants/baseboard/include/baseboard/ec.h      |  67 --
 [IGNORE]  .../variants/baseboard/include/baseboard/gpio.h    |  15 -
 [IGNORE]  .../baseboard/include/baseboard/hda_verb.h         | 687 -------------------
 [IGNORE]  .../baseboard/include/baseboard/variants.h         |  14 -
 [IGNORE]  .../intel/icelake_rvp/variants/icl_u/Makefile.inc  |   5 -
 [IGNORE]  .../intel/icelake_rvp/variants/icl_u/devicetree.cb | 345 ----------
 [IGNORE]  .../intel/icelake_rvp/variants/icl_u/gpio.c        | 112 ----
 [IGNORE]  .../intel/icelake_rvp/variants/icl_y/Makefile.inc  |   5 -
 [IGNORE]  .../intel/icelake_rvp/variants/icl_y/devicetree.cb | 345 ----------
 [IGNORE]  .../intel/icelake_rvp/variants/icl_y/gpio.c        | 112 ----
 src/mainboard/pcengines/apu2/BiosCallOuts.c        |   2 +-
 - redundant changed on v4.19.0.1: string.h not needed, include separation line not needed
 src/mainboard/pcengines/apu2/Kconfig               |   3 +
 - [ ] select GENERIC_SPD_BIN, SPI_FLASH, SPI_FLASH_WINBOND not needed for compilation, but may be needed for including given implmentation
   - [X] check if adding those decrease number of different objects in build directories
     - makes no difference for apu2, maybe that configs are selected anyway?
 src/mainboard/pcengines/apu2/Makefile.inc          |   3 -
 - redundant addition of pmultil.c removed, redundant compilation of s1_button in romstage removed
 src/mainboard/pcengines/apu2/Makefile.inc          |   4 +-
 - TBD
 src/mainboard/pcengines/apu2/mainboard.c           |   8 +-
 - preserve upstream comment style
 src/mainboard/pcengines/apu2/mptable.c             | 129 ++++
 - dead code
 src/mainboard/pcengines/apu2/pmutil.c              |  24 +
 - TBD
 src/mainboard/pcengines/apu2/romstage.c            |   5 +
 - redundant includes removed
 .../pcengines/apu2/variants/apu5/bootorder         | Bin 4095 -> 4096 bytes
 - TBD
[IGNORE] src/mainboard/siemens/mc_apl1/Makefile.inc         |   2 +
[IGNORE] .../siemens/mc_apl1/{variants/mc_apl2 => }/post.c  |   0
[IGNORE] .../siemens/mc_apl1/variants/mc_apl1/lcd_panel.c   |  50 +-
[IGNORE] .../siemens/mc_apl1/variants/mc_apl2/Makefile.inc  |   2 -
[IGNORE] .../siemens/mc_apl1/variants/mc_apl4/lcd_panel.c   |  49 +-
[IGNORE] .../siemens/mc_apl1/variants/mc_apl5/lcd_panel.c   |  51 +-
[IGNORE] .../siemens/mc_apl1/variants/mc_apl6/Kconfig       |  16 +
[IGNORE] .../siemens/mc_apl1/variants/mc_apl7/lcd_panel.c   |  49 +-
[IGNORE] src/mainboard/siemens/mc_ehl/Kconfig               |   2 +-
[IGNORE] .../siemens/mc_ehl/variants/mc_ehl3/Kconfig        |   1 +
[IGNORE] .../siemens/mc_ehl/variants/mc_ehl3/Makefile.inc   |   1 +
[IGNORE] .../siemens/mc_ehl/variants/mc_ehl3/devicetree.cb  |   6 +-
[IGNORE] .../siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c    |  95 +++
[IGNORE] .../siemens/mc_ehl/variants/mc_ehl3/mainboard.c    |   2 +-
[IGNORE] src/mainboard/sifive/hifive-unleashed/media.c      |   2 +-
 src/northbridge/amd/pi/00730F01/northbridge.c      |  17 +
 - remove dead code
 src/northbridge/amd/pi/Kconfig                     |   4 -
 - 4.19 version is preferred
 [IGNORE] src/soc/amd/cezanne/Makefile.inc                   |   2 -
 [IGNORE] src/soc/amd/cezanne/acpi/globalnvs.asl             |  13 +-
 [IGNORE] src/soc/amd/cezanne/agesa_acpi.c                   |   5 +-
 [IGNORE] src/soc/amd/cezanne/aoac.c                         |   2 +-
 [IGNORE] src/soc/amd/cezanne/chip.c                         |   7 -
 [IGNORE] src/soc/amd/cezanne/chipset.cb                     |   2 +-
 [IGNORE] src/soc/amd/cezanne/fch.c                          |   2 +-
 [IGNORE] src/soc/amd/cezanne/gpio.c                         |   2 +-
 [IGNORE] src/soc/amd/cezanne/include/soc/i2c.h              |   2 +-
 [IGNORE] src/soc/amd/cezanne/include/soc/nvs.h              |  13 +-
 [IGNORE] src/soc/amd/cezanne/uart.c                         |   2 +-
 [IGNORE] src/soc/amd/common/Kconfig.common                  |   6 +
 [IGNORE] src/soc/amd/common/Makefile.inc                    |   2 +
 [IGNORE] src/soc/amd/common/block/acpi/cppc.c               |   5 -
 [IGNORE] src/soc/amd/common/block/acpi/gpio.c               |   2 +-
 [IGNORE] src/soc/amd/common/block/cpu/cpu.c                 |   9 +
 [IGNORE] src/soc/amd/common/block/gpio/gpio.c               |   1 -
 [IGNORE] src/soc/amd/glinda/Makefile.inc                    |   8 +-
 [IGNORE] src/soc/amd/glinda/acpi/globalnvs.asl              |  15 +-
 [IGNORE] src/soc/amd/glinda/agesa_acpi.c                    |   5 +-
 [IGNORE] src/soc/amd/glinda/aoac.c                          |   2 +-
 [IGNORE] src/soc/amd/glinda/chip.c                          |   7 -
 [IGNORE] src/soc/amd/glinda/chipset.cb                      |   2 +-
 [IGNORE] src/soc/amd/glinda/espi_util.c                     |   5 +-
 [IGNORE] src/soc/amd/glinda/fch.c                           |   2 +-
 [IGNORE] src/soc/amd/glinda/gpio.c                          |   2 +-
 [IGNORE] src/soc/amd/glinda/include/soc/i2c.h               |   2 +-
 [IGNORE] src/soc/amd/glinda/include/soc/nvs.h               |  15 +-
 [IGNORE] src/soc/amd/glinda/uart.c                          |   2 +-
 [IGNORE] src/soc/amd/mendocino/Makefile.inc                 |   5 -
 [IGNORE] src/soc/amd/mendocino/acpi/globalnvs.asl           |  15 +-
 [IGNORE] src/soc/amd/mendocino/acpi/pci_int_defs.asl        |   2 -
 [IGNORE] src/soc/amd/mendocino/acpi/rtc_workaround.asl      |  28 -
 [IGNORE] src/soc/amd/mendocino/acpi/soc.asl                 |   2 -
 [IGNORE] src/soc/amd/mendocino/agesa_acpi.c                 |   5 +-
 [IGNORE] src/soc/amd/mendocino/aoac.c                       |   2 +-
 [IGNORE] src/soc/amd/mendocino/chip.c                       |   9 -
 [IGNORE] src/soc/amd/mendocino/chip.h                       |   2 -
 [IGNORE] src/soc/amd/mendocino/chipset_mendocino.cb         |   2 +-
 [IGNORE] src/soc/amd/mendocino/chipset_rembrandt.cb         |   2 +-
 [IGNORE] src/soc/amd/mendocino/cpu.c                        |   2 -
 [IGNORE] src/soc/amd/mendocino/espi_util.c                  |   2 +-
 [IGNORE] src/soc/amd/mendocino/fch.c                        |   2 +-
 [IGNORE] src/soc/amd/mendocino/gpio.c                       |   2 +-
 [IGNORE] src/soc/amd/mendocino/include/soc/i2c.h            |   2 +-
 [IGNORE] src/soc/amd/mendocino/include/soc/nvs.h            |  15 +-
 [IGNORE] src/soc/amd/mendocino/reset.c                      |   2 -
 [IGNORE] src/soc/amd/mendocino/uart.c                       |   2 +-
 [IGNORE] src/soc/amd/phoenix/Makefile.inc                   |   8 +-
 [IGNORE] src/soc/amd/phoenix/acpi/globalnvs.asl             |  15 +-
 [IGNORE] src/soc/amd/phoenix/agesa_acpi.c                   |   5 +-
 [IGNORE] src/soc/amd/phoenix/aoac.c                         |   2 +-
 [IGNORE] src/soc/amd/phoenix/chip.c                         |   7 -
 [IGNORE] src/soc/amd/phoenix/chipset.cb                     |   2 +-
 [IGNORE] src/soc/amd/phoenix/espi_util.c                    |   4 +-
 [IGNORE] src/soc/amd/phoenix/fch.c                          |   2 +-
 [IGNORE] src/soc/amd/phoenix/gpio.c                         |   2 +-
 [IGNORE] src/soc/amd/phoenix/include/soc/i2c.h              |   2 +-
 [IGNORE] src/soc/amd/phoenix/include/soc/nvs.h              |  15 +-
 [IGNORE] src/soc/amd/phoenix/uart.c                         |   2 +-
 [IGNORE] src/soc/amd/picasso/Makefile.inc                   |   2 -
 [IGNORE] src/soc/amd/picasso/acpi.c                         |   2 +-
 [IGNORE] src/soc/amd/picasso/acpi/globalnvs.asl             |  16 +-
 [IGNORE] src/soc/amd/picasso/agesa_acpi.c                   |   5 +-
 [IGNORE] src/soc/amd/picasso/aoac.c                         |   2 +-
 [IGNORE] src/soc/amd/picasso/chip.c                         |   7 -
 [IGNORE] src/soc/amd/picasso/chipset.cb                     |   2 +-
 [IGNORE] src/soc/amd/picasso/fch.c                          |   2 +-
 [IGNORE] src/soc/amd/picasso/gpio.c                         |   2 +-
 [IGNORE] src/soc/amd/picasso/include/soc/i2c.h              |   2 +-
 [IGNORE] src/soc/amd/picasso/include/soc/nvs.h              |  16 +-
 [IGNORE] src/soc/amd/picasso/uart.c                         |   2 +-
 [IGNORE] src/soc/amd/stoneyridge/Kconfig                    |   9 -
 [IGNORE] src/soc/amd/stoneyridge/acpi.c                     |   2 +-
 [IGNORE] src/soc/amd/stoneyridge/acpi/globalnvs.asl         |  16 +-
 [IGNORE] src/soc/amd/stoneyridge/chip.c                     |   7 -
 [IGNORE] src/soc/amd/stoneyridge/chipset_cz.cb              |   2 +-
 [IGNORE] src/soc/amd/stoneyridge/chipset_st.cb              |   2 +-
 [IGNORE] src/soc/amd/stoneyridge/gpio.c                     |   2 +-
 [IGNORE] src/soc/amd/stoneyridge/include/soc/i2c.h          |   2 +-
 [IGNORE] src/soc/amd/stoneyridge/include/soc/nvs.h          |  18 +-
 [IGNORE] src/soc/amd/stoneyridge/northbridge.c              |  12 +-
 [IGNORE] src/soc/amd/stoneyridge/uart.c                     |   2 +-
 [IGNORE] src/soc/intel/alderlake/Kconfig                    |  26 +-
 [IGNORE] src/soc/intel/alderlake/include/soc/gpio_defs.h    |   3 -
 [IGNORE] .../intel/alderlake/include/soc/gpio_defs_pch_s.h  |   3 -
 [IGNORE] src/soc/intel/alderlake/include/soc/romstage.h     |   1 -
 [IGNORE] src/soc/intel/alderlake/pmutil.c                   |   2 +-
 [IGNORE] src/soc/intel/alderlake/romstage/Makefile.inc      |   1 +
 [IGNORE] src/soc/intel/alderlake/romstage/fsp_params.c      |  16 +-
 [IGNORE] src/soc/intel/alderlake/romstage/romstage.c        |  66 +-
 [IGNORE] src/soc/intel/alderlake/romstage/ux.c              |  18 +
 [IGNORE] src/soc/intel/alderlake/romstage/ux.h              |   3 +
 [IGNORE] src/soc/intel/apollolake/acpi/gpio.asl             |   2 +-
 [IGNORE] src/soc/intel/apollolake/bootblock/bootblock.c     |   2 +-
 [IGNORE] src/soc/intel/apollolake/chip.c                    |   2 +-
 [IGNORE] src/soc/intel/apollolake/chip.h                    |   2 +-
 [IGNORE] src/soc/intel/apollolake/gpio_apl.c                |   2 +-
 [IGNORE] src/soc/intel/apollolake/gpio_glk.c                |   2 +-
 [IGNORE] src/soc/intel/apollolake/include/soc/gpio.h        |   4 +-
 [IGNORE] src/soc/intel/apollolake/include/soc/pm.h          |  33 +-
 [IGNORE] src/soc/intel/apollolake/smihandler.c              |   2 +-
 [IGNORE] src/soc/intel/baytrail/include/soc/pm.h            | 194 +++---
 [IGNORE] src/soc/intel/braswell/bootblock/bootblock.c       |   2 +-
 [IGNORE] src/soc/intel/braswell/gpio.c                      |   4 +-
 [IGNORE] src/soc/intel/braswell/gpio_support.c              |   3 +-
 [IGNORE] src/soc/intel/braswell/include/soc/pm.h            | 186 +++---
 [IGNORE] src/soc/intel/braswell/lpc_init.c                  |   4 +-
 [IGNORE] src/soc/intel/braswell/ramstage.c                  |   2 +-
 [IGNORE] src/soc/intel/braswell/smihandler.c                |   6 +-
 [IGNORE] src/soc/intel/cannonlake/acpi/gpio.asl             |   3 +-
 [IGNORE] src/soc/intel/cannonlake/bootblock/bootblock.c     |   2 +-
 [IGNORE] src/soc/intel/cannonlake/bootblock/pch.c           |   3 +-
 [IGNORE] src/soc/intel/cannonlake/chip.c                    |   2 +-
 [IGNORE] src/soc/intel/cannonlake/chip.h                    |   4 +-
 [IGNORE] src/soc/intel/cannonlake/gpio.c                    |   2 +-
 [IGNORE] src/soc/intel/cannonlake/gpio_cnp_h.c              |   2 +-
 [IGNORE] src/soc/intel/cannonlake/gpio_common.c             |   2 +-
 [IGNORE] src/soc/intel/cannonlake/include/soc/gpio.h        |   2 +-
 [IGNORE] src/soc/intel/cannonlake/include/soc/gpio_defs.h   |   3 -
 [IGNORE] .../intel/cannonlake/include/soc/gpio_defs_cnp_h.h |   3 -
 [IGNORE] src/soc/intel/cannonlake/pmutil.c                  |   6 +-
 [IGNORE] src/soc/intel/common/block/cnvi/cnvi.c             |   1 -
 [IGNORE] src/soc/intel/common/block/cpu/mp_init.c           |   2 -
 [IGNORE] src/soc/intel/common/block/crashlog/crashlog.c     |  10 +-
 [IGNORE] src/soc/intel/common/block/cse/cse.c               |   1 -
 [IGNORE] src/soc/intel/common/block/cse/cse_lite.c          |   6 +
 [IGNORE] src/soc/intel/common/block/dsp/dsp.c               |   1 -
 [IGNORE] src/soc/intel/common/block/fast_spi/Makefile.inc   |   2 +-
 [IGNORE] src/soc/intel/common/block/graphics/graphics.c     |  16 -
 [IGNORE] src/soc/intel/common/block/hda/hda.c               |   1 -
 [IGNORE] .../intel/common/block/include/intelblocks/cse.h   |   3 +
 [IGNORE] .../common/block/include/intelblocks/p2sblib.h     |   1 -
 [IGNORE] .../common/block/include/intelblocks/pmclib.h      |   3 +
 [IGNORE] src/soc/intel/common/block/lpc/lpc.c               |   7 -
 [IGNORE] src/soc/intel/common/block/p2sb/p2sb.c             |   2 +-
 [IGNORE] src/soc/intel/common/block/pmc/pmclib.c            |  50 +-
 [IGNORE] src/soc/intel/common/block/scs/sd.c                |   1 -
 [IGNORE] src/soc/intel/common/block/smbus/smbus.c           |   1 +
 [IGNORE] src/soc/intel/common/block/sram/sram.c             |   1 -
 [IGNORE] .../intel/common/block/systemagent/systemagent.c   |   4 -
 [IGNORE] src/soc/intel/denverton_ns/bootblock/uart.c        |   5 +-
 [IGNORE] src/soc/intel/denverton_ns/chip.c                  |   2 +-
 [IGNORE] src/soc/intel/denverton_ns/gpio.c                  |   2 +-
 [IGNORE] src/soc/intel/denverton_ns/include/soc/pmc.h       |   4 +
 [IGNORE] src/soc/intel/elkhartlake/acpi/gpio.asl            |   3 +-
 [IGNORE] src/soc/intel/elkhartlake/chip.c                   |   2 +-
 [IGNORE] src/soc/intel/elkhartlake/chip.h                   |   4 +-
 [IGNORE] src/soc/intel/elkhartlake/gpio.c                   |   2 +-
 [IGNORE] src/soc/intel/elkhartlake/include/soc/gpio.h       |   2 +-
 [IGNORE] src/soc/intel/elkhartlake/include/soc/gpio_defs.h  |   4 -
 [IGNORE] src/soc/intel/elkhartlake/pmutil.c                 |   4 +-
 [IGNORE] src/soc/intel/icelake/Kconfig                      | 205 ------
 [IGNORE] src/soc/intel/icelake/Makefile.inc                 |  51 --
 [IGNORE] src/soc/intel/icelake/acpi.c                       | 182 ------
 [IGNORE] src/soc/intel/icelake/acpi/gpio.asl                | 105 ---
 [IGNORE] src/soc/intel/icelake/acpi/pch_hda.asl             |  68 --
 [IGNORE] src/soc/intel/icelake/acpi/pci_irqs.asl            | 124 ----
 [IGNORE] src/soc/intel/icelake/acpi/pcie.asl                | 369 -----------
 [IGNORE] src/soc/intel/icelake/acpi/scs.asl                 | 121 ----
 [IGNORE] src/soc/intel/icelake/acpi/serialio.asl            |  75 ---
 [IGNORE] src/soc/intel/icelake/acpi/southbridge.asl         |  42 --
 [IGNORE] src/soc/intel/icelake/acpi/xhci.asl                |  58 --
 [IGNORE] src/soc/intel/icelake/bootblock/bootblock.c        |  33 -
 [IGNORE] src/soc/intel/icelake/bootblock/pch.c              | 118 ----
 [IGNORE] src/soc/intel/icelake/bootblock/report_platform.c  | 191 ------
 [IGNORE] src/soc/intel/icelake/chip.c                       | 155 -----
 [IGNORE] src/soc/intel/icelake/chip.h                       | 198 ------
 [IGNORE] src/soc/intel/icelake/cpu.c                        | 172 -----
 [IGNORE] src/soc/intel/icelake/elog.c                       | 117 ----
 [IGNORE] src/soc/intel/icelake/espi.c                       |  68 --
 [IGNORE] src/soc/intel/icelake/finalize.c                   |  74 ---
 [IGNORE] src/soc/intel/icelake/fsp_params.c                 | 196 ------
 [IGNORE] src/soc/intel/icelake/gpio.c                       | 201 ------
 [IGNORE] src/soc/intel/icelake/gspi.c                       |  17 -
 [IGNORE] src/soc/intel/icelake/i2c.c                        |  43 --
 [IGNORE] src/soc/intel/icelake/include/soc/bootblock.h      |  14 -
 [IGNORE] src/soc/intel/icelake/include/soc/cpu.h            |  30 -
 [IGNORE] src/soc/intel/icelake/include/soc/espi.h           |  29 -
 [IGNORE] src/soc/intel/icelake/include/soc/gpe.h            |   8 -
 [IGNORE] src/soc/intel/icelake/include/soc/gpio.h           |  16 -
 [IGNORE] src/soc/intel/icelake/include/soc/gpio_defs.h      | 262 --------
 [IGNORE] src/soc/intel/icelake/include/soc/gpio_soc_defs.h  | 284 --------
 [IGNORE] src/soc/intel/icelake/include/soc/iomap.h          |  61 --
 [IGNORE] src/soc/intel/icelake/include/soc/irq.h            |  93 ---
 [IGNORE] src/soc/intel/icelake/include/soc/itss.h           |  13 -
 [IGNORE] src/soc/intel/icelake/include/soc/me.h             |  44 --
 [IGNORE] src/soc/intel/icelake/include/soc/msr.h            |  12 -
 [IGNORE] src/soc/intel/icelake/include/soc/nvs.h            |   8 -
 [IGNORE] src/soc/intel/icelake/include/soc/p2sb.h           |  11 -
 [IGNORE] src/soc/intel/icelake/include/soc/pch.h            |  10 -
 [IGNORE] src/soc/intel/icelake/include/soc/pci_devs.h       | 192 ------
 [IGNORE] src/soc/intel/icelake/include/soc/pcr_ids.h        |  31 -
 [IGNORE] src/soc/intel/icelake/include/soc/pm.h             | 162 -----
 [IGNORE] src/soc/intel/icelake/include/soc/pmc.h            | 141 ----
 [IGNORE] src/soc/intel/icelake/include/soc/ramstage.h       |  14 -
 [IGNORE] src/soc/intel/icelake/include/soc/romstage.h       |  19 -
 [IGNORE] src/soc/intel/icelake/include/soc/serialio.h       |  35 -
 [IGNORE] src/soc/intel/icelake/include/soc/smbus.h          |   8 -
 [IGNORE] src/soc/intel/icelake/include/soc/soc_chip.h       |   8 -
 [IGNORE] src/soc/intel/icelake/include/soc/systemagent.h    |  26 -
 [IGNORE] src/soc/intel/icelake/include/soc/usb.h            | 138 ----
 [IGNORE] src/soc/intel/icelake/lockdown.c                   |  62 --
 [IGNORE] src/soc/intel/icelake/me.c                         | 154 -----
 [IGNORE] src/soc/intel/icelake/p2sb.c                       |  30 -
 [IGNORE] src/soc/intel/icelake/pmc.c                        |  96 ---
 [IGNORE] src/soc/intel/icelake/pmutil.c                     | 280 --------
 [IGNORE] src/soc/intel/icelake/reset.c                      |  17 -
 [IGNORE] src/soc/intel/icelake/romstage/Makefile.inc        |   6 -
 [IGNORE] src/soc/intel/icelake/romstage/fsp_params.c        |  77 ---
 [IGNORE] src/soc/intel/icelake/romstage/romstage.c          | 125 ----
 [IGNORE] src/soc/intel/icelake/romstage/systemagent.c       |  30 -
 [IGNORE] src/soc/intel/icelake/sd.c                         |  24 -
 [IGNORE] src/soc/intel/icelake/smihandler.c                 |  36 -
 [IGNORE] src/soc/intel/icelake/spi.c                        |  17 -
 [IGNORE] src/soc/intel/icelake/systemagent.c                |  68 --
 [IGNORE] src/soc/intel/icelake/uart.c                       |  12 -
 [IGNORE] src/soc/intel/jasperlake/acpi/gpio.asl             |   3 +-
 [IGNORE] src/soc/intel/jasperlake/chip.c                    |   2 +-
 [IGNORE] src/soc/intel/jasperlake/chip.h                    |   3 +-
 [IGNORE] src/soc/intel/jasperlake/gpio.c                    |   2 +-
 [IGNORE] src/soc/intel/jasperlake/include/soc/gpio.h        |   2 +-
 [IGNORE] src/soc/intel/jasperlake/include/soc/gpio_defs.h   |   3 -
 [IGNORE] src/soc/intel/jasperlake/pmutil.c                  |   6 +-
 [IGNORE] src/soc/intel/meteorlake/Kconfig                   |  20 +-
 [IGNORE] src/soc/intel/meteorlake/acpi.c                    |  59 ++
 [IGNORE] src/soc/intel/meteorlake/chip.h                    |  22 +-
 [IGNORE] src/soc/intel/meteorlake/include/soc/gpio_defs.h   |   3 -
 [IGNORE] src/soc/intel/meteorlake/include/soc/romstage.h    |   1 -
 [IGNORE] src/soc/intel/meteorlake/pmutil.c                  |   2 +-
 [IGNORE] src/soc/intel/meteorlake/romstage/fsp_params.c     |   6 +-
 [IGNORE] src/soc/intel/meteorlake/romstage/romstage.c       |  12 +-
 [IGNORE] src/soc/intel/skylake/acpi/gpio.asl                |   2 +-
 [IGNORE] src/soc/intel/skylake/chip.h                       |   2 +-
 [IGNORE] src/soc/intel/skylake/gpio.c                       |   2 +-
 [IGNORE] src/soc/intel/skylake/include/soc/gpio.h           |   4 +-
 [IGNORE] src/soc/intel/skylake/include/soc/gpio_defs.h      |   4 +-
 [IGNORE] src/soc/intel/skylake/pmutil.c                     |   4 +-
 [IGNORE] src/soc/intel/tigerlake/Kconfig                    |   4 +-
 [IGNORE] src/soc/intel/tigerlake/acpi/gpio.asl              |   3 +-
 [IGNORE] src/soc/intel/tigerlake/acpi/gpio_pch_h.asl        |   2 +-
 [IGNORE] src/soc/intel/tigerlake/chip.c                     |   2 +-
 [IGNORE] src/soc/intel/tigerlake/chip.h                     |   3 +-
 [IGNORE] src/soc/intel/tigerlake/fsp_params.c               |   6 +-
 [IGNORE] src/soc/intel/tigerlake/gpio.c                     |   2 +-
 [IGNORE] src/soc/intel/tigerlake/gpio_pch_h.c               |   2 +-
 [IGNORE] src/soc/intel/tigerlake/include/soc/gpio.h         |   2 +-
 [IGNORE] src/soc/intel/tigerlake/include/soc/gpio_defs.h    |   3 -
 [IGNORE] .../intel/tigerlake/include/soc/gpio_defs_pch_h.h  |   3 -
 [IGNORE] src/soc/intel/tigerlake/pmutil.c                   |   6 +-
 [IGNORE] src/soc/intel/tigerlake/romstage/fsp_params.c      |   2 +-
 [IGNORE] src/soc/intel/xeon_sp/Kconfig                      |   3 +-
 [IGNORE] src/soc/intel/xeon_sp/acpi/gpio.asl                |   2 +-
 [IGNORE] src/soc/intel/xeon_sp/cpx/chip.c                   |   2 +-
 [IGNORE] src/soc/intel/xeon_sp/cpx/chip.h                   |   2 +-
 [IGNORE] src/soc/intel/xeon_sp/include/soc/gpio.h           |   2 +-
 [IGNORE] .../intel/xeon_sp/lbg/include/soc/gpio_soc_defs.h  |   4 -
 [IGNORE] src/soc/intel/xeon_sp/lbg/soc_gpio.c               |   3 +-
 [IGNORE] src/soc/intel/xeon_sp/skx/chip.c                   |   2 +-
 [IGNORE] src/soc/intel/xeon_sp/skx/chip.h                   |   4 +-
 [IGNORE] src/soc/mediatek/mt8188/pmif_spmi.c                |   3 +-
 [IGNORE] src/soc/samsung/exynos5250/alternate_cbfs.c        |   2 +-
 src/southbridge/amd/pi/hudson/Kconfig              |  52 --
 - 4.19 version is preferred
 src/vendorcode/amd/pi/Lib/amdlib.c                 |  12 +-
 - 4.19 version is preferred
 [IGNORE] .../intel/fsp/fsp2_0/meteorlake/FspmUpd.h          | 724 ++++++++++-----------
 [IGNORE] .../intel/fsp/fsp2_0/meteorlake/FspsUpd.h          | 320 +++++----
 [IGNORE] src/vendorcode/siemens/hwilib/hwilib.c             |  28 +-
 [IGNORE] src/vendorcode/siemens/hwilib/hwilib.h             |   4 +-
 util/amdfwtool/amdfwtool.c                         |  93 ++-
 - 4.19 version is preferred
 util/amdfwtool/amdfwtool.h                         |  15 +
 - 4.19 version is preferred
 util/amdfwtool/data_parse.c                        |  67 ++
 - 4.19 version is preferred
 util/cbmem/cbmem.c                                 |   4 +
 - 4.19 version is preferred
 [IGNORE] util/inteltool/gpio.c                              |   1 +
 [IGNORE] util/inteltool/gpio_groups.c                       |   7 +
 [IGNORE] util/inteltool/gpio_names/emmitsburg.h             | 440 +++++++++++++
 [IGNORE] util/inteltool/gpio_names/gpio_groups.h            |   5 +
 util/inteltool/pcr.c                               |   1 +
 - 4.19 version is preferred
 util/release/genrelnotes                           |   2 -
 - 4.19 version is preferred
 394 files changed, 3845 insertions(+), 9838 deletions(-)

pietrushnic and others added 30 commits May 8, 2024 13:32
Signed-off-by: Kamil Wcislo <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
This commit modifies the smbios_mainboard_serial_number function in the
apu2 mainboard code. It now first attempts to read the serial number
from flash. If this attempt fails, or if the serial number read from
flash is invalid (either 0x00 or 0xff), it will then read the serial
number from the NIC.

This change allows for more flexibility in obtaining the serial number,
which can be helpful in situations where the NIC is not available or the
serial number in the NIC is not set.

The commit also includes necessary includes and defines for the new
functionality. The obtained information is exposed in SMBIOS tables.

Signed-off-by: Maciej Pijanowski <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
This commit improves the mainboard_enable function in the apu2 mainboard
code. It includes a check for console availability and logs the total
available memory. It also reads memory configuration from GPIO 49 and
50, and reads the SPD data. If ECC is enabled, it logs that information
as well. This additional logging will assist in debugging and system
analysis, and ensure that the boot process is compatible with legacy
systems and meets customer expectations.

Signed-off-by: Piotr Król <[email protected]>
This commit introduces a change in the apu2 mainboard code to enable
power on after a power failure. A new definition for PM_RTC_SHADOW has
been added and a bit manipulation operation has been included to set the
necessary bit for this feature. This change improves the robustness of
the system in case of unexpected power outages.

Signed-off-by: Piotr Król <[email protected]>
This commit introduces the ability for users to customize the feature
set built into the iPXE ROM by specifying a custom general.h file. It
also allows users to specify a custom bootmenu file.

The Makefile has been updated to handle these new configuration options
and will fail the build process if the specified files do not exist.

Additionally, several environment variables related to Kconfig have been
unexported to prevent potential conflicts with the iPXE build process.

Signed-off-by: Kamil Wcislo <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Include iPXE ROM as genroms/pxe.rom instead of a device-specific one.

Signed-off-by: Kamil Wcislo <[email protected]>
On apu5 the S1 button is not present. Its GPIO is used as a
SIMSWAP.

Signed-off-by: Michał Żygowski <[email protected]>
…en offset invalid

Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
This commit addresses an issue where ECC was not functioning correctly
due to all memory being marked as excluded from ECC checking and error
reporting. This was caused by an incorrect setting in systems without
UMA (no integrated graphics).

The fix involves temporarily disabling DRAM ECC scrubbing, clearing
reserved bits in register D18F3xB8, disabling the ECC exclusion range,
and then re-enabling DRAM ECC scrubbing. This ensures that ECC functions
as expected and improves system stability.

Signed-off-by: Piotr Król <[email protected]>
- Iteration over devices in add_ivrs_device_entries were simplified to
decrease complexity.
- Code was structured to satisfy checkpatch

Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4
Signed-off-by: Timothy Pearson <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Michał Witwicki <[email protected]>
pietrushnic and others added 26 commits May 14, 2024 15:19
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Marek Kasiewicz <[email protected]>
This commit updates the GPIO configuration for apu3, apu4, and apu7
boards. It also removes unused macros for SIO_PORT and SERIAL_DEV.

Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
This commit adds support for sercon-port in the SeaBIOS for the
pcengines mainboard. The sercon-port file is added to the cbfs-files
if the CONFIG_SEABIOS_SERCON_PORT_FILE is set.

Signed-off-by: Piotr Król <[email protected]>
This commit removes the condition for the 'board.fmd' path, making it
the default path regardless of the VBOOT configuration. The changes have
been applied to the configurations of pcengines_apu2, pcengines_apu3,
pcengines_apu4, pcengines_apu5, and pcengines_apu6. A new file
'board.fmd' has also been added to 'src/mainboard/pcengines/apu2'.

Signed-off-by: Michał Żygowski <[email protected]>
on apu3,4,5 and 6

Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
apu7 is an apu3 with different NICs (Intel i225).

For now, it doesn't support iPXE network booting.

Change-Id: I495879f1527643b217f9facb07dace5d70175a3e
Signed-off-by: Michał Kopeć <[email protected]>
The coreboot build date shown by print_sign_of_life at early boot was
incorrectly presented in yyyyddmm format, when it should have been
yyyymmdd.

pcengines/coreboot#517 contains a complete
explanation of the history of this date string.

Signed-off-by: Mark Mentovai <[email protected]>
The amdfwtool expects firmware location to be passed in hexadecimal
format. When CONFIG_AMDFW_OUTSIDE_CBFS the firmware location is calculated
by int-add call which produces decimal output.

Use shell printf to generate a hexadecimal value of HUDSON_FWM_POSITION.

TEST=prepare simple FMD file with AMD_FW region at 0x20000, select
CONFIG_AMDFW_OUTSIDE_CBFS and build PC Engines apu2 board

Change-Id: Ib4b03f971b88acbc3392b66e084babe738659ea6
Signed-off-by: Michał Żygowski <[email protected]>
@mkopec mkopec changed the base branch from dasharo to dasharo-4.21 June 3, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants