Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

103 get connection should pass parameters on to psycopg2 #104

Merged
merged 11 commits into from
Apr 17, 2024
Merged

103 get connection should pass parameters on to psycopg2 #104

merged 11 commits into from
Apr 17, 2024

Conversation

fatchat
Copy link
Contributor

@fatchat fatchat commented Apr 7, 2024

No description provided.

@fatchat fatchat linked an issue Apr 7, 2024 that may be closed by this pull request
get_connection should pass parameters on to psycopg2 #103
Closed
@fatchat fatchat mentioned this pull request Apr 7, 2024
Closed
@fatchat fatchat marked this pull request as ready for review April 16, 2024 03:54
@Ishankoradia
Copy link
Contributor

Ishankoradia commented Apr 17, 2024 •
edited
Loading

Screenshot 2024-04-17 at 11 30 34

@fatchat __del__ is raising exceptions because references are lost.

Ishankoradia
Ishankoradia previously approved these changes Apr 17, 2024
View reviewed changes
@Ishankoradia
Copy link
Contributor

SSHTunnelForwarder takes pkey as path to the private key file.
DDP_backend needs to save the private key to a file and then pass the path here.

@Ishankoradia Ishankoradia self-requested a review April 17, 2024 07:48
@Ishankoradia Ishankoradia merged commit 78ef9c5 into main Apr 17, 2024
1 check passed
@Ishankoradia Ishankoradia deleted the 103-get_connection-should-pass-parameters-on-to-psycopg2 branch April 17, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishankoradia Ishankoradia Ishankoradia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_connection should pass parameters on to psycopg2
2 participants
@fatchat @Ishankoradia