Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_connection should pass parameters on to psycopg2 #103

Closed
fatchat opened this issue Apr 4, 2024 · 0 comments · Fixed by #104
Closed

get_connection should pass parameters on to psycopg2 #103

fatchat opened this issue Apr 4, 2024 · 0 comments · Fixed by #104
Assignees
@fatchat

Comments

@fatchat
Copy link
Contributor

fatchat commented Apr 4, 2024 •
edited
Loading

utils/postgres.py needs an update:

In PostgresClient.get_connection, all parameters in conn_info need to be passed as kwargs to psycopg2.connect

So get_connection needs to move from named parameters to dict / kwargs

And __init__ needs to pass on conn_info as dict / kwargs
@fatchat fatchat mentioned this issue Apr 4, 2024
Closed
@fatchat fatchat transferred this issue from DalgoT4D/DDP_backend Apr 4, 2024
@fatchat fatchat self-assigned this Apr 4, 2024
@fatchat fatchat changed the title sync_sources to work with ssh tunnels get_connection should pass parameters on to psycopg2 Apr 4, 2024
@fatchat fatchat linked a pull request Apr 7, 2024 that will close this issue
103 get connection should pass parameters on to psycopg2 #104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatchat fatchat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

103 get connection should pass parameters on to psycopg2 DalgoT4D/dbt-automation
1 participant
@fatchat