Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge two constructors in footerlink #36

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix: merge two constructors in footerlink #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions components/footer-link/footer-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,23 @@ class FooterLink extends HTMLElement {
super();
const shadow = this.attachShadow({ mode: "open" });
shadow.appendChild(template.content.cloneNode(true));
this.linkElement = shadow.getElementById("link");
this.updateLink(this.getAttribute("href"));
}

static get observedAttributes() {
return ["href"];
}

constructor() {
this.linkElement = shadow.getElementById("link");
this.updateLink(this.getAttribute("href"));
}

attributeChangedCallback(name, oldValue, newValue) {
if (name === "href") {
this.updateLinkHref(newValue);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생성자를 병합했더니, 여기에 메서드 이름에도 오타 발견되어 같이 정정하였습니다. updateLinkHref() -> updateLink()

}
}
attributeChangedCallback(name, oldValue, newValue) {
if (name === "href") {
this.updateLink(newValue);
}
}

updateLink(href) {
this.linkElement.setAttribute("href", href);
}
updateLink(href) {
this.linkElement.setAttribute("href", href);
}
}

window.customElements.define("footer-link", FooterLink);