fix: merge two constructors in footerlink #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaleSeo
commented
Jun 11, 2024
|
|
||
| attributeChangedCallback(name, oldValue, newValue) { | ||
| if (name === "href") { | ||
| this.updateLinkHref(newValue); |
There was a problem hiding this comment.
생성자를 병합했더니, 여기에 메서드 이름에도 오타 발견되어 같이 정정하였습니다. updateLinkHref() -> updateLink()
sounmind
approved these changes
Jun 11, 2024
|
제가 조금 일찍 확인했어야하는데 늦었네요 ㅠㅠ. 두 분 모두 확인해주셔서 감사드립니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
웹사이트를 둘러보다가 우연히 콘솔에서 다음 오류를 발견하였습니다. 간단한 버그라서 바로 고칩니다.