-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔖 v0.6.3-rc2 #50
Merged
Merged
🔖 v0.6.3-rc2 #50
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
413f7d6
:construction: testing clang-tidy-17 checks
JoshuaLau0220 9344a34
:art: fix linting in clang-tidy-17
JoshuaLau0220 91e51dc
:bar_chart: delete unstable tab related dofiles
JoshuaLau0220 747a171
:bar_chart: changed RUN_TESTS script to bash because python subproces…
JoshuaLau0220 e7552b3
:bug: explicitly check if parallel is installed for scripts
JoshuaLau0220 04b02ad
:fire: delete python-based RUN_TESTS scripts
JoshuaLau0220 0fca210
:bar_chart: updated testcases
JoshuaLau0220 b718454
🔀 Merge pull request #41 from DVLab-NTU/lint/clang-tidy-17
JoshuaLau0220 3a0ec59
:bug: trivial-optimization removes non-matching cz gates
JoshuaLau0220 169892d
🔀 Merge pull request #45 from DVLab-NTU/bug/trivial-optimization-wron…
JoshuaLau0220 a145678
🐛 Fix filter cnots by checking matched control and target qubits (#458)
chinyi0523 449785c
🐛 Fix starting point in back tracking Gaussian Elimination procedure …
chinyi0523 fc29018
🐛 Fix initializing the extractor by not removing phase nodes
chinyi0523 c241351
🎨 Lint
chinyi0523 e2b3b7b
🔀 Merge pull request #47 from DVLab-NTU/hotfix-boolean-matrix
chinyi0523 3ee605e
:children_crossing: add guards for tensor calculation
JoshuaLau0220 96fc253
:racehorse: improve make lint speed
JoshuaLau0220 6a264e8
Merge pull request #48 from DVLab-NTU/sanity/zx2ts-safely-abort
JoshuaLau0220 7abc506
:bug: qsyn does not guard unrecognized options
JoshuaLau0220 2b7d3dc
:bug: fix #42
JoshuaLau0220 de48870
:bug: qsyn panics on printing QCirs with SWAP gates
JoshuaLau0220 c6b9f88
🔀 Merge branch 'bug/#42' of https://github.com/DVLab-NTU/qsyn into bu…
JoshuaLau0220 434ccf1
🔀 Merge pull request #49 from DVLab-NTU/bug/#42
JoshuaLau0220 46cf3cd
🐳 remove unnecessary GNU parallel installation
JoshuaLau0220 c304d1f
[no ci] Merge branch 'develop' of https://github.com/DVLab-NTU/qsyn i…
JoshuaLau0220 add47f7
🐛 Break cases
chinyi0523 50b1982
📊 Add optimization flow testcase
chinyi0523 4a4dc4a
Merge branch 'develop' of https://github.com/DVLab-NTU/qsyn into develop
chinyi0523 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,5 @@ RUN dnf install -y \ | |
clang \ | ||
cmake \ | ||
lapack-devel \ | ||
openblas-devel | ||
openblas-devel \ | ||
parallel | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,8 @@ FROM fedora:38 AS runner | |
RUN dnf install -y \ | ||
lapack \ | ||
openblas-serial \ | ||
libomp | ||
libomp \ | ||
parallel | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same, don't need parallel |
||
|
||
COPY --from=builder /app/build/qsyn /usr/local/bin/qsyn | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,28 @@ | ||
#!/usr/bin/env bash | ||
|
||
if [ ! -x "$(command -v parallel)" ]; then | ||
echo "Error: GNU parallel is not installed!!" | ||
exit 1 | ||
fi | ||
|
||
format_one() { | ||
clang-format -i "$1" | ||
} | ||
export -f format_one | ||
|
||
lint_one() { | ||
clang-tidy "$1" --quiet 2>&1 | grep -v "warnings generated" | grep -v "warning generated" | ||
clang-tidy -p build "$1" --quiet 2>&1 | grep -v -E "warnings? generated" | ||
} | ||
export -f lint_one | ||
|
||
FILES=$(find ./src -regex '.*\.[ch]pp' -type f) | ||
CPPS=$(find ./src -regex '.*\.cpp' -type f) | ||
|
||
# Format all files first to avoid linting errors | ||
echo "Formatting files..." | ||
parallel -j"$(nproc)" format_one ::: "$FILES" | ||
echo "Generating compile commands..." | ||
cmake -S . -B build -DCMAKE_EXPORT_COMPILE_COMMANDS=1 > /dev/null | ||
echo "Linting files..." | ||
parallel -j"$(nproc)" lint_one ::: "$FILES" | ||
parallel -j"$(nproc)" lint_one ::: "$CPPS" | ||
echo "Done" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed in env.Dockerfile, only direct dependencies should be here