Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 v0.6.3-rc2 #50

Merged
merged 28 commits into from
Dec 26, 2023
Merged

🔖 v0.6.3-rc2 #50

merged 28 commits into from
Dec 26, 2023

Conversation

JoshuaLau0220
Copy link
Collaborator

@JoshuaLau0220 JoshuaLau0220 commented Dec 26, 2023

Check List

  1. Does your submission pass tests by running make test?
  2. If you have specified a [no ci] tag, does your submission also pass tests by running make test-docker?
  3. Have you linted your code locally with make lint before submission?

Changed

  • Catch for bad_alloc when doing tensor calculation
  • make lint now don't check .hpp files (would be covered by .cpp file checks)

Fixed

JoshuaLau0220 and others added 23 commits December 11, 2023 04:03
improved clang-tidy-17 compatibility / rewrite test scripts in Bash
…gly-remove-gates

🐛 trivial-optimization removes non-matching cz gates
Copy link
Contributor

@madmaxieee madmaxieee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -5,4 +5,5 @@ RUN dnf install -y \
clang \
cmake \
lapack-devel \
openblas-devel
openblas-devel \
parallel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed in env.Dockerfile, only direct dependencies should be here

@@ -14,7 +14,8 @@ FROM fedora:38 AS runner
RUN dnf install -y \
lapack \
openblas-serial \
libomp
libomp \
parallel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, don't need parallel

@chinyi0523 chinyi0523 merged commit 3b6c19d into main Dec 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants