Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to allow free-text editing in the dropdown field of Edit Item #3608

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

toniprieto
Copy link
Contributor

@toniprieto toniprieto commented Nov 4, 2024

References

Description

  • Added a toggle button to allow free-text input in dropdown fields during item editing.
  • It also fixes an issue that caused an error when clicking the "Clear selection" option that .

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

Edit a dropdown field associated with a vocabulary in the Edit Item page (e.g., dc.language.iso or dc.type), and verify that free-text input can be enabled or disabled using the button shown below, and that uncontrolled values can be saved.

Also, verify that clicking the "Clear selection" option clears the content and no longer generates an error in the console.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

… edition and fix error when clicking "Clear selection" option
@tdonohue tdonohue added bug improvement 1 APPROVAL pull request only requires a single approval to merge component: submission component: Item (Archived) Item display or editing port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Nov 4, 2024
@tdonohue
Copy link
Member

tdonohue commented Nov 4, 2024

@MW3000 : Since you reported this issue in #3583, I'm pinging you in case you are interested in helping test this possible solution.

@MW3000
Copy link
Contributor

MW3000 commented Nov 5, 2024

I cherry-picked the commit to DSpace 8 and tested it. It works exactly as expected and it is a very nice solution 👍

@MW3000
Copy link
Contributor

MW3000 commented Nov 5, 2024

Could it be easily extended to also apply to hierarchical vocabularies, @toniprieto?

@toniprieto
Copy link
Contributor Author

@MW3000 Yes, it’s possible. I’ve added a new commit to implement it

@MW3000
Copy link
Contributor

MW3000 commented Nov 6, 2024

Thank you so much @toniprieto. I tested it on DSpace 8 and it works perfectly and is a really elegant UI solution.

Copy link
Member

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and I'm +1 overall, I just wondered if it was worth putting the enabledFreeTextEditing option into config to it is easier for admins to toggle without having to edit the component itself?

@toniprieto
Copy link
Contributor Author

@kshepherd Sorry for the late reply. It shouldn't be necessary to edit the component; enabledFreeTextEditing is toggled when clicking the button added in this PR. Or are you asking about setting the initial value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: Item (Archived) Item display or editing component: submission improvement port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: 👍 Reviewer Approved
4 participants