Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back possibility to enter free text in “Edit Item”, even when input forms are associated with a vocabulary #3583

Open
MW3000 opened this issue Oct 28, 2024 · 4 comments · May be fixed by #3608
Assignees
Labels
affects: 8.x Issue impacts 8.x releases bug component: Item (Archived) Item display or editing component: submission

Comments

@MW3000
Copy link
Contributor

MW3000 commented Oct 28, 2024

Describe the bug

In DSpace 8, in “Edit Item” (<dspace>/items/<id>/edit/metadata), if a metadata field is associated with a controlled vocabulary (list or hierarchical) in the submission form, it is no longer possible to enter free form text in such a field in “Edit Item”, as there is the same vocabulary presented as in the submission forms as the only option.

While we offer controlled vocabularies to help our submitters to pick e.g. reasonable licenses, it is crucial that our editorial staff has the possiblitly to enter free form text in those fields, to accomodate more advanced use cases.

Screenshot 2024-10-28 at 14 36 46

This change leads us to the situation were metadata editing has to be done on database level, or via the Rest API or a CSV export/import operation!!! This is an extremely serious bug for us.

To Reproduce

Steps to reproduce the behavior:

  1. Associate a controlled vocabulary with an input field in submission-forms.xml like <input-type value-pairs-name=“publication-licenses">dropdown</input-type>
  2. Choose to edit this field under <dspace>/items/<id>/edit/metadata
  3. Try to enter a free form text!

Expected behavior

It is essential that with “Edit Item” there is a possibilty to add free from text beyond a controlled vocabulary.

Possible solutions would be:

  1. Return to the old behaviour, where no controlled vocabularies were presented in “Edit Item”
  2. Add the option to enable or disable the use of controlled vocabularies for “Edit Item”
  3. Add the option to edit free form text in addition to pick from a controlled vocabulary
@MW3000 MW3000 added bug needs triage New issue needs triage and/or scheduling labels Oct 28, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Oct 28, 2024
@tdonohue tdonohue added component: Item (Archived) Item display or editing affects: 8.x Issue impacts 8.x releases help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Oct 28, 2024
@MW3000
Copy link
Contributor Author

MW3000 commented Oct 28, 2024

It might have been introduced here: #2653

@tdonohue
Copy link
Member

@MW3000 : Yes, I believe this was implemented in #2653 by @toniprieto . But, the bug you are detailing might be specific to the dropdown field because that's one of the few fields which doesn't allow free-text entry in the Submission form. So, if the field allows free text entry in Submission, then it will allow it in this Item Edit. But, you are rightly pointing out that if the field does not allow free-text entry in Submission, then "Edit Item" will also block that ability.

I'm not sure of the best solution myself, but maybe there'd be a way to allow "Edit Item" to also support free-text entry, even if the controlled vocabulary is a dropdown.

In any case, I've pulled this over the maintenance board to see if we can find a volunteer.

@toniprieto
Copy link
Contributor

Oh, I hadn’t thought of this issue. I'll try to send a possible solution in the coming days. I had considered adding a button to enable free text input, something like this:

enable-free-text

As a workaround, an uncontrolled value could now be added by following these steps:

  • Delete the current one
  • In the text area for entering new metadata, input the desired value (without having selected the metadata field)
  • Then select the metadata field to enter (in this case, dc.rights.uri)
  • Save the new value

@MW3000
Copy link
Contributor Author

MW3000 commented Oct 28, 2024

Thank you, @toniprieto. The solution with the button seems very good to me. Also thank you for the workaround.

Together with an option to edit free form text, it is a big win to have controlled vocabularies in “Edit Item”

@tdonohue tdonohue moved this from 📋 To Do to 🙋 Needs Reviewers Assigned in DSpace 8.x and 7.6.x Maintenance Nov 4, 2024
@tdonohue tdonohue removed the help wanted Needs a volunteer to claim to move forward label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: 8.x Issue impacts 8.x releases bug component: Item (Archived) Item display or editing component: submission
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging a pull request may close this issue.

3 participants