-
Notifications
You must be signed in to change notification settings - Fork 153
Backlog of Outstanding DPG Full Submissions: #555
Comments
As far as I can see, none of the projects above are available to review yet. Is there any way one can help on this? |
Hi @Ainali, thanks for your offer to help; very much appreciated: The short answer to your question is Yes 🙂 Here's some background: We started accepting submissions with an inadequate Google Form that did not integrate nicely with this repo, and we would store their answers on a spreadsheet, which would then need to be manually encoded into json files and added to this repo. We recently (April 2021) upgraded our submission form (repo, live form), and that integration now happens automatically, so we can keep up with any submissions we receive through the new form, but we are behind encoding and reviewing the ones that we received with the old Google Form. Thus, the first step would be to encode those entries into JSON, and @nathanbaleeta will do the first pass at reviewing them, and reaching out to the project contact if additional information is required from them. Because that spreadsheet contains some personal information, I don't feel comfortable giving anyone else access directly, but (option A) I can copy/paste the info that we received from any of the above projects into plain text, and you can encode it into JSON We could also look into scripting it (option B), and converting from CSV into JSON, but it will require some additional work, it may or may not be worth it. I can provide a "cleaned up" version of that spreadsheet that contains all of the projects above, with the personal information removed. The script would look like a more complex version of this related one. Let me know if you are interested in helping out with Option A or Option B. Also, @nathanfletcher may be able to help. |
Thanks @lacabra! Me and my colleague @ericherman could have a go at option B. |
@Ainali & @ericherman: Amazing! 🙌 Here is a copy of the spreadsheet that contains the submissions from the projects listed above not yet encoded into JSON (and linked to their respective PR). I count 19 of them. My recommendation is to export it as CSV. Take a look and let us know what you think. 3 observations:
Happy to answer any questions. If you need a real time chat, we can chat here. |
Just commenting to let you know that we are about halfway through scripting the conversion. |
Thanks for the update @Ainali, and thanks for your efforts on this front 🙏 |
@lacabra we have a rough draft now ( https://github.com/ericherman/dpg-csv-to-json ). We have not yet tried to run the checks, nor split the data into separate submission files. |
@ericherman Cool, cool; let me know when you do the split and run the checks, eager to take a look then. |
@lacabra seems to pass the checks now. I believe all you need to do is:
And the result files should be in the |
The docs at https://github.com/unicef/publicgoods-candidates/blob/master/docs/development.md#ci---continous-integration say
but We aligned the file naming with the expectations of script, rather than the docs. |
Works towards DPGAlliance#555
Works towards DPGAlliance#555 Co-authored-by: Eric Herman <[email protected]>
@Ainali, yes, it looks very good to me, and as you can see the CI passes, which is also a very good sign. I would like to get confirmation from @nathanbaleeta, who is the person who will review and processes PRs like that for final confirmation, and then you can submit all the rest. This is very exciting 🙌 |
Works towards DPGAlliance#555 Co-authored-by: Eric Herman <[email protected]>
Works towards DPGAlliance#555 ( created with https://github.com/ericherman/dpg-csv-to-json ) Co-authored-by: Eric Herman <[email protected]>
Works towards DPGAlliance#555 ( created with https://github.com/ericherman/dpg-csv-to-json ) Co-authored-by: Eric Herman <[email protected]>
Works towards unicef#555 ( created with https://github.com/ericherman/dpg-csv-to-json ) Co-authored-by: Eric Herman <[email protected]>
Works towards unicef#555 ( created with https://github.com/ericherman/dpg-csv-to-json ) Co-authored-by: Eric Herman <[email protected]>
Works towards unicef#555 ( created with https://github.com/ericherman/dpg-csv-to-json ) Co-authored-by: Eric Herman <[email protected]>
Works towards unicef#555 ( created with https://github.com/ericherman/dpg-csv-to-json ) Co-authored-by: Eric Herman <[email protected]>
This looks great @Ainali, thanks a lot, you and @ericherman both rock! 🙌 I have updated the description of this issue to link to all the PRs, and as you can see they are all covered, and @nathanbaleeta has already started working on the one you submitted yesterday. Much appreciated! 🙏 |
Pleasure to be able to contribute. Keep up the great work! <3 |
Add DPG: ICE (Immunization Calculation Engine, Issue #555)
Closing this issue as the new tracker board serves as the current single source of truth for all projects previously existent in the backlog list. Thanks. |
The following nominated projects made full submissions but have not yet been reviewed:
The text was updated successfully, but these errors were encountered: