This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Map tooltips #1921
Merged
Map tooltips #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| detachdCallback: {value: detached} | ||
| } | ||
| ) | ||
| }) |
| init(); | ||
|
|
||
| tooltipText.text(function(){ | ||
| return self.attr('desc'); |
|
The tooltips aren't working in Ffx. Pulled that out into the existing Ffx bug issue because it might be the same thing. #1748 . |
|
@gemfarmer this may not work in browsers that don't support Custom Elements v0 natively (basically, everyone except Chrome) because the polyfill we're using doesn't support type extension for SVG elements. 😠 |
|
@shawnbot @ericronne @meiqimichelle now works on 🔥 🐺 |
|
Also, the hound warnings are old. The grievances it is voicing are not real. As far as I can tell, at least |
|
😄 I will review once Federalist builds! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue(s) #1520
😎 PREVIEW
Changes proposed in this pull request:
eiti-tooltipcomponent to be used in conjunction with the<title>elementeiti-tooltipcan be used like so:<title is="eiti-tooltip">and supportsdescandaltattributes.desc: text to be displayedalt: applied to thearia-labelattribute on the tooltipEnhancement possibility: make tooltips clickable. Add
hrefattribute support/cc @shawnbot @ericronne