Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Chart and map bugs in ffx #1748

Closed
meiqimichelle opened this issue Aug 16, 2016 · 3 comments · Fixed by #1958
Closed

Chart and map bugs in ffx #1748

meiqimichelle opened this issue Aug 16, 2016 · 3 comments · Fixed by #1958
Milestone
Sprint-SingingSwan

Comments

@meiqimichelle
Copy link
Contributor

meiqimichelle commented Aug 16, 2016 •
edited
Loading

when the default year has "no data":
screenshot 2016-08-16 10 49 45
@meiqimichelle meiqimichelle added this to the Sprint-PuffyPastry milestone Aug 16, 2016
@meiqimichelle meiqimichelle assigned shawnbot and unassigned gemfarmer Sep 1, 2016
@meiqimichelle meiqimichelle changed the title Interactive county map: bug in ffx when the default year has "no data" Interactive county map: bugs in ffx Sep 9, 2016
@meiqimichelle meiqimichelle changed the title Interactive county map: bugs in ffx Map/chart bugs in ffx Sep 9, 2016
@meiqimichelle meiqimichelle changed the title Map/chart bugs in ffx Interactive county map: bug in ffx when the default year has "no data" Sep 9, 2016
@meiqimichelle
Copy link
Contributor Author

We won't know if the above issue is solved until we fix this other issue, which is that the charts aren't working in FFx right now.
screenshot 2016-09-12 15 56 20

@meiqimichelle meiqimichelle changed the title Interactive county map: bug in ffx when the default year has "no data" Chart and map bugs in ffx Sep 12, 2016
@meiqimichelle
Copy link
Contributor Author

meiqimichelle commented Sep 14, 2016 •
edited
Loading

Tooltips are also not showing up. The custom element code isn't even running. So, maybe all these issues are related to something in Ffx not recognizing custom elements. Fixed with #1921!

screenshot 2016-09-14 09 56 06

@meiqimichelle meiqimichelle mentioned this issue Sep 14, 2016
Merged
@shawnbot
Copy link
Contributor

Oof. Firefox appears to be throwing an error inside d3-svg-legend, specifically here. I think what's happening is that we're trying to access a text node inside a linked SVG and that's throwing an error because Firefox has more restrictive cross-origin rules than Chrome?

shawnbot pushed a commit that referenced this issue Sep 15, 2016
fix #1748
78de658 
d3-svg-legend throws an error in some no-data cases. We can catch those
and continue on our end, because an error really just means that the
legend won't render.
@shawnbot shawnbot mentioned this issue Sep 15, 2016
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint-SingingSwan
Development

Successfully merging a pull request may close this issue.

Fix Firefox map/chart issues DOI-ONRR/doi-extractives-data
3 participants
@shawnbot @gemfarmer @meiqimichelle