Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Commit

Permalink
Pin package dependencies to specific versions
Browse files Browse the repository at this point in the history
In #1565 I ran into an issue where changes were brought in to the
minified javascript bundle that were unrelated to the changes made in
the PR. This was due to NPM packages which were pulled in under
the compatability version spec `pkg: ^1.2.3` but which differed from the
versions used to build the current release in `dev`.

This PR only pins the versions of the three libraries that interfered
with #1563, but it might be worthwhile to ammend it and pin all of the
dependency versions to ensure that all development environments are
building with the same code.

Cheers!
  • Loading branch information
dmsnell committed Jul 5, 2016
1 parent b934a73 commit 4831880
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
"async": "^0.9.0",
"colorbrewer": "0.0.2",
"custom-event": "^1.0.0",
"d3": "^3.5.5",
"d3": "3.5.16",
"document-register-element": "^0.5.3",
"immutable": "^3.7.6",
"jquery": "^1.11.3",
"jquery": "1.11.3",
"list.js": "^1.1.1",
"lodash": "^3.10.1",
"queue-async": "^1.0.7",
"queue-async": "1.0.7",
"topojson": "git://github.com/mbostock/topojson.git#oversize",
"webpack": "*"
},
Expand Down

0 comments on commit 4831880

Please sign in to comment.