This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Design: Glossary - clicking on terms in list does not open/close definition #1563
Comments
dmsnell
added a commit
to dmsnell/doi-extractives-data
that referenced
this issue
Jul 4, 2016
Closes DOI-ONRR#1563 Previously, when opening the gallery and reading through the list of terms, one had to click on the chevron next to a term itself in order to open or close the definition. This patch allows for performing the same action but also through clicking on the term itself, expanding the click area and making for what I feel is a more expected behavior. **Caveats** - I'm not familiar with the codebase, so while this seems to _work_, I don't know if it's _right_ for the project, also, I wasn't even sure if I needed to submit the changes to the minified code in this PR. - The actual work seems like it's happening inside of the `List()` which made it more difficult to figure out. This is also why I'm not convinced that I made the right changes in the right places. Thanks!
dmsnell
added a commit
to dmsnell/doi-extractives-data
that referenced
this issue
Jul 4, 2016
Closes DOI-ONRR#1563 Previously, when opening the gallery and reading through the list of terms, one had to click on the chevron next to a term itself in order to open or close the definition. This patch allows for performing the same action but also through clicking on the term itself, expanding the click area and making for what I feel is a more expected behavior. **Caveats** - I'm not familiar with the codebase, so while this seems to _work_, I don't know if it's _right_ for the project, also, I wasn't even sure if I needed to submit the changes to the minified code in this PR. - The actual work seems like it's happening inside of the `List()` which made it more difficult to figure out. This is also why I'm not convinced that I made the right changes in the right places. - There are lingering issues with the cursor: should it be a pointer when hovering over the glossary terms? Thanks!
dmsnell
added a commit
to dmsnell/doi-extractives-data
that referenced
this issue
Jul 5, 2016
Closes DOI-ONRR#1563 Previously, when opening the gallery and reading through the list of terms, one had to click on the chevron next to a term itself in order to open or close the definition. This patch allows for performing the same action but also through clicking on the term itself, expanding the click area and making for what I feel is a more expected behavior. **Caveats** - I'm not familiar with the codebase, so while this seems to _work_, I don't know if it's _right_ for the project, also, I wasn't even sure if I needed to submit the changes to the minified code in this PR. - The actual work seems like it's happening inside of the `List()` which made it more difficult to figure out. This is also why I'm not convinced that I made the right changes in the right places. - There are lingering issues with the cursor: should it be a pointer when hovering over the glossary terms? Thanks!
dmsnell
added a commit
to dmsnell/doi-extractives-data
that referenced
this issue
Jul 5, 2016
In DOI-ONRR#1565 I ran into an issue where changes were brought in to the minified javascript bundle that were unrelated to the changes made in the PR. This was due to NPM packages which were pulled in under the compatability version spec `pkg: ^1.2.3` but which differed from the versions used to build the current release in `dev`. This PR only pins the versions of the three libraries that interfered with DOI-ONRR#1563, but it might be worthwhile to ammend it and pin all of the dependency versions to ensure that all development environments are building with the same code. Cheers!
dmsnell
added a commit
to dmsnell/doi-extractives-data
that referenced
this issue
Jul 5, 2016
In DOI-ONRR#1565 I ran into an issue where changes were brought in to the minified javascript bundle that were unrelated to the changes made in the PR. This was due to NPM packages which were pulled in under the compatability version spec `pkg: ^1.2.3` but which differed from the versions used to build the current release in `dev`. This PR only pins the versions of the three libraries that interfered with DOI-ONRR#1563, but it might be worthwhile to ammend it and pin all of the dependency versions to ensure that all development environments are building with the same code. Cheers!
dmsnell
added a commit
to dmsnell/doi-extractives-data
that referenced
this issue
Jul 19, 2016
In DOI-ONRR#1565 I ran into an issue where changes were brought in to the minified javascript bundle that were unrelated to the changes made in the PR. This was due to NPM packages which were pulled in under the compatability version spec `pkg: ^1.2.3` but which differed from the versions used to build the current release in `dev`. This PR only pins the versions of the three libraries that interfered with DOI-ONRR#1563, but it might be worthwhile to ammend it and pin all of the dependency versions to ensure that all development environments are building with the same code. Cheers!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The glossary is an incredibly cool element on the website, but I noticed that in order to open or close a term definition in the list of terms I have to click on the chevron next to each term instead of being able to click on the term itself or being able to click anywhere on the term row.
The chevron makes for a small click target and I think that the glossary would be much more useful if the same click handler were present on the row as is on the chevron.
Tested in Safari, Firefox, and Chrome on Mac.
The text was updated successfully, but these errors were encountered: