Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7 support #117

Closed
Xyene opened this issue Dec 5, 2015 · 5 comments
Closed

PHP 7 support #117

Xyene opened this issue Dec 5, 2015 · 5 comments
Labels
executors feature

Comments

@Xyene
Copy link
Member

Xyene commented Dec 5, 2015

http://php.net/manual/en/migration70.new-features.php
@Xyene
Copy link
Member Author

Xyene commented Dec 19, 2015

Installed on Herculaneum. The PHP5 executor works just fine for PHP7 (only the ini file regex needs a change). Perhaps it's time for php_executor?

@quantum5
Copy link
Member

Agreed.

Xyene added a commit that referenced this issue Dec 23, 2015
@Xyene @quantum5
Add PHP7 executor #117
cc4241a
quantum5 added a commit that referenced this issue Dec 23, 2015
@quantum5
Refactor common PHP code into PHPExecutor #117
f26b59a
quantum5 added a commit that referenced this issue Dec 23, 2015
@quantum5
PHP7 uses a different .ini organization #117
3299fa7
@quantum5
Copy link
Member

This is misguided. PHP 7 simply replaces PHP 5 and can use the same executor. We should simply merge the executors and dump PHP 5 judges.

@quantum5
Copy link
Member

quantum5 commented Dec 2, 2017

This will be similar to what we plan on doing for Java.

Xyene added a commit that referenced this issue Dec 9, 2017
@Xyene
Drop dual PHP/PHP7 executors as per #117
cb2c9f9
@Xyene
Copy link
Member Author

Xyene commented Dec 9, 2017

Dropped.

@Xyene Xyene closed this as completed Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
executors feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quantum5 @Xyene