Skip to content

Commit

Permalink
Drop dual PHP/PHP7 executors as per #117
Browse files Browse the repository at this point in the history
  • Loading branch information
Xyene committed Dec 9, 2017
1 parent 5686f91 commit cb2c9f9
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 25 deletions.
14 changes: 11 additions & 3 deletions dmoj/executors/PHP.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
from .php_executor import PHPExecutor
from dmoj.executors.base_executor import ScriptExecutor


class Executor(PHPExecutor):
class Executor(ScriptExecutor):
name = 'PHP'
ext = '.php'
command = 'php'
command_paths = ['php5', 'php']
command_paths = ['php7', 'php5', 'php']

fs = ['.*/php[\w-]*\.ini$', '.*/conf.d/.*\.ini$']

This comment has been minimized.

Copy link
@quantum5

quantum5 Dec 9, 2017

Member

I thought you said PHP worked with NOENT inis?

This comment has been minimized.

Copy link
@Xyene

Xyene Dec 9, 2017

Author Member

It does but it's a bit loud, so I figured I'd leave these in here to be less loud in some installs


test_program = '<?php while($f = fgets(STDIN)) echo $f;'

def get_cmdline(self):
return ['php', self._code]
7 changes: 0 additions & 7 deletions dmoj/executors/PHP7.py

This file was deleted.

15 changes: 0 additions & 15 deletions dmoj/executors/php_executor.py

This file was deleted.

0 comments on commit cb2c9f9

Please sign in to comment.