-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extension management #243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldbr
force-pushed
the
main_FEAT_extension-management
branch
12 times, most recently
from
November 11, 2024 10:53
d42baae
to
5707b7c
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
7 times, most recently
from
November 13, 2024 12:33
c85d1c2
to
4136147
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
3 times, most recently
from
November 13, 2024 15:36
4048dd9
to
74ebf20
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
from
December 10, 2024 11:59
74ebf20
to
3a29f6c
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
2 times, most recently
from
December 10, 2024 12:58
2f61638
to
4b1f4cc
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
6 times, most recently
from
December 10, 2024 15:40
39e8ff2
to
dbc8a27
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
7 times, most recently
from
December 17, 2024 13:55
a81b78a
to
a983088
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
from
December 18, 2024 09:51
5bbbd0d
to
20bccc6
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
from
December 18, 2024 10:15
acee94d
to
5362bb4
Compare
ryuwd
previously approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I looked through all the files and while this is a big PR I see that many of the changes involve sensible reorganisation of files and refactoring. The documentation added here is thoughtful and well written.
aldbr
force-pushed
the
main_FEAT_extension-management
branch
3 times, most recently
from
December 18, 2024 16:54
432e5a6
to
ce423a4
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
2 times, most recently
from
December 19, 2024 15:58
a5ae50b
to
ca9c712
Compare
aldbr
force-pushed
the
main_FEAT_extension-management
branch
from
December 20, 2024 08:08
ca9c712
to
7e91084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we try to stabilize the repo:
Project management:
diracx-web-components
anddiracx-web
concurrently in dev mode (tsup --watch
andnext dev
). Running both processes in parallel was cpu-intensive. Instead of that, we use thetranspile
option of NextJS instead (NextJS is responsible for cross compilingdiracx-web-components
when needed). Therefore, only 1 process is used for both workspaces in dev mode.diracx-web-components
by adding the components in a/src
directory.Gubbins
gubbins
in the npm workspaces so that it uses a local version ofdiracx-web-components
gubbins
application to matchgubbins
backend services.Owner
)DataTable
) to create a new component (OwnerMonitor
)use a component with different parameters (.JobMonitor
): may be it would be easier by adding a new parameter in thegubbins JobDB
Needs:
Would be good to have: