Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extension management #243

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

aldbr
Copy link
Collaborator

@aldbr aldbr commented Nov 4, 2024

Here we try to stabilize the repo:

Project management:

  • drop lerna: it was only used to run diracx-web-components and diracx-web concurrently in dev mode (tsup --watch and next dev). Running both processes in parallel was cpu-intensive. Instead of that, we use the transpile option of NextJS instead (NextJS is responsible for cross compiling diracx-web-components when needed). Therefore, only 1 process is used for both workspaces in dev mode.
  • restructure diracx-web-components by adding the components in a /src directory.
  • move every packages from CJS to ESM
  • upgrade to ESLint 9, because 8 was deprecated. This also involved upgrading to NextJS 15 and consequently to MUI 6, this was a significant upgrade.
  • add/update documentation:
    • user guide
    • dev guide
    • admin guide

Gubbins

  • add a basic test for the extension, just to make sure the login page can load fine and the user can login. This will prevent merging not compatible PRs 🙃
  • add gubbins in the npm workspaces so that it uses a local version of diracx-web-components
  • add a github workflow for the extension as an example.
  • make new gubbins application to match gubbins backend services.
    • create a complete new application (adding a new Owner)
    • reuse an inner component (DataTable) to create a new component (OwnerMonitor)
    • use a component with different parameters (JobMonitor): may be it would be easier by adding a new parameter in the gubbins JobDB.

Needs:

Would be good to have:

@aldbr aldbr force-pushed the main_FEAT_extension-management branch 12 times, most recently from d42baae to 5707b7c Compare November 11, 2024 10:53
@aldbr aldbr force-pushed the main_FEAT_extension-management branch 7 times, most recently from c85d1c2 to 4136147 Compare November 13, 2024 12:33
@aldbr aldbr mentioned this pull request Nov 13, 2024
3 tasks
@aldbr aldbr force-pushed the main_FEAT_extension-management branch 3 times, most recently from 4048dd9 to 74ebf20 Compare November 13, 2024 15:36
@aldbr aldbr force-pushed the main_FEAT_extension-management branch from 74ebf20 to 3a29f6c Compare December 10, 2024 11:59
@aldbr aldbr force-pushed the main_FEAT_extension-management branch 2 times, most recently from 2f61638 to 4b1f4cc Compare December 10, 2024 12:58
@aldbr aldbr force-pushed the main_FEAT_extension-management branch 6 times, most recently from 39e8ff2 to dbc8a27 Compare December 10, 2024 15:40
@aldbr aldbr force-pushed the main_FEAT_extension-management branch 7 times, most recently from a81b78a to a983088 Compare December 17, 2024 13:55
@aldbr aldbr force-pushed the main_FEAT_extension-management branch from 5bbbd0d to 20bccc6 Compare December 18, 2024 09:51
@aldbr aldbr requested a review from ryuwd December 18, 2024 10:00
@aldbr aldbr force-pushed the main_FEAT_extension-management branch from acee94d to 5362bb4 Compare December 18, 2024 10:15
ryuwd
ryuwd previously approved these changes Dec 18, 2024
Copy link

@ryuwd ryuwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I looked through all the files and while this is a big PR I see that many of the changes involve sensible reorganisation of files and refactoring. The documentation added here is thoughtful and well written.

@aldbr aldbr force-pushed the main_FEAT_extension-management branch 3 times, most recently from 432e5a6 to ce423a4 Compare December 18, 2024 16:54
@aldbr aldbr force-pushed the main_FEAT_extension-management branch 2 times, most recently from a5ae50b to ca9c712 Compare December 19, 2024 15:58
@aldbr aldbr marked this pull request as ready for review December 19, 2024 16:01
@aldbr aldbr force-pushed the main_FEAT_extension-management branch from ca9c712 to 7e91084 Compare December 20, 2024 08:08
@aldbr aldbr merged commit ac43f13 into DIRACGrid:main Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants