Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve datatable #238

Merged
merged 2 commits into from
Dec 5, 2024
Merged

feat: improve datatable #238

merged 2 commits into from
Dec 5, 2024

Conversation

aldbr
Copy link
Collaborator

@aldbr aldbr commented Oct 21, 2024 •
edited
Loading

diracx-web-components tables are managed by tan stack. It is used to:

  • select rows
  • resize columns
  • hide/show columns
  • pagination

tan stack also provides a library to virtualize tables but it does not seem to nicely work with MUI Table, so I kept react virtuoso.

I modified the stories accordingly and added some integration tests to make sure the main features of the Job Monitor keeps working.

@aldbr aldbr force-pushed the main_FEAT_improve-datatable branch 3 times, most recently from 2780923 to 5858dab Compare October 30, 2024 17:32
@ryuwd ryuwd self-requested a review October 31, 2024 10:47
@aldbr aldbr force-pushed the main_FEAT_improve-datatable branch from 5858dab to 594b21a Compare October 31, 2024 13:15
@aldbr aldbr marked this pull request as ready for review October 31, 2024 13:30
@aldbr aldbr mentioned this pull request Oct 31, 2024
Closed
@aldbr aldbr mentioned this pull request Nov 13, 2024
Merged
15 tasks
ryuwd
ryuwd reviewed Nov 19, 2024
View reviewed changes
Copy link

@ryuwd ryuwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like very sensible refactoring and improvements throughout. I have only small suggestions about style and the login UI

packages/diracx-web-components/components/DashboardLayout/DashboardDrawer.tsx Outdated Show resolved Hide resolved
packages/diracx-web-components/components/Login/LoginForm.tsx Show resolved Hide resolved
packages/diracx-web-components/components/Login/LoginForm.tsx Outdated Show resolved Hide resolved
packages/diracx-web-components/components/shared/DataTable.tsx Outdated Show resolved Hide resolved
packages/diracx-web-components/components/shared/DataTable.tsx Outdated Show resolved Hide resolved
packages/diracx-web-components/components/shared/FilterToolbar.tsx Outdated Show resolved Hide resolved
@aldbr aldbr requested a review from ryuwd December 4, 2024 16:44
ryuwd
ryuwd previously approved these changes Dec 4, 2024
View reviewed changes
Copy link

@ryuwd ryuwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@aldbr aldbr force-pushed the main_FEAT_improve-datatable branch 2 times, most recently from 07b44cb to 98e4693 Compare December 5, 2024 09:19
@aldbr aldbr force-pushed the main_FEAT_improve-datatable branch from 98e4693 to f3927ee Compare December 5, 2024 09:35
@aldbr aldbr merged commit a482103 into DIRACGrid:main Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuwd ryuwd ryuwd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldbr @ryuwd