Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Azure Key Vault for Container App Secrets #374

Merged
merged 1 commit into from
May 30, 2024

Conversation

DrizzlyOwl
Copy link
Collaborator

@DrizzlyOwl DrizzlyOwl commented May 29, 2024

This change migrates Container App Secret Environment Variables into Key Vault Secrets.

In order for this to deploy successfully, the Container App Managed Identity must be granted the Key Vault Secret User role so that it can read the values from Key Vault when the Container boots.

If you already have a Key Vault deployed, you can leverage it by setting the existing_key_vault value.

@DrizzlyOwl DrizzlyOwl force-pushed the use-key-vault-for-secret branch 4 times, most recently from 232ff47 to 492ce72 Compare May 30, 2024 16:03
@DrizzlyOwl DrizzlyOwl marked this pull request as ready for review May 30, 2024 16:03
@DrizzlyOwl DrizzlyOwl requested a review from Stretch96 May 30, 2024 16:04
@DrizzlyOwl DrizzlyOwl force-pushed the use-key-vault-for-secret branch from 492ce72 to 73f8a9b Compare May 30, 2024 16:21
@DrizzlyOwl DrizzlyOwl merged commit 590b8e0 into main May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants