Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for secrets from KV #67

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Add support for secrets from KV #67

merged 4 commits into from
Nov 18, 2024

Conversation

lonegunmanb
Copy link
Member

Describe your changes

Issue number

Release pr for #55 and should fix #52.

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb
Copy link
Member Author

This pr should be halt due to this requirement:

When using key_vault_secret_id, ignore_changes should be used to ignore any changes to value.

Now we haven't ignore value, and I don't think we have a way to customize ignore_changes list based on whether we've set key_vault_secret_id or not. I'd like to try azapi_update.

@DrizzlyOwl
Copy link

I did something similar here DFE-Digital/terraform-azurerm-container-apps-hosting#374

@lonegunmanb
Copy link
Member Author

This pr should be halt due to this requirement:

When using key_vault_secret_id, ignore_changes should be used to ignore any changes to value.

Now we haven't ignore value, and I don't think we have a way to customize ignore_changes list based on whether we've set key_vault_secret_id or not. I'd like to try azapi_update.

After studied current implementation I'm pretty sure that the document is incorrect. I'm the author who contributed this feature to the provider, and I found that this notice in the document was added by the previous author of my pr (my pr was rebased on his pr), and I've improved the logic how we handle key_vault_secret_id and value (when key_vault_secret_id was set, value would be set empty by default in read), so we don't need to add value in ignore_changes list anymore.

I'll continue this pr.

@lonegunmanb lonegunmanb merged commit 7c760bd into main Nov 18, 2024
5 checks passed
@lonegunmanb lonegunmanb deleted the secrets-from-kv branch November 18, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Support for key vault references
3 participants