Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit submission guidance #463

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

davidjamesstone
Copy link
Contributor

@davidjamesstone davidjamesstone commented Sep 11, 2024

image

image

@colinrotherham
Copy link
Contributor

@davidjamesstone Mind hitting "Edit" and setting the base branch?

So the commit from #462 doesn't show up in the Files changed tab

@davidjamesstone davidjamesstone changed the base branch from main to feature/290019-support-details September 11, 2024 14:53
Base automatically changed from feature/290019-support-details to main September 16, 2024 12:37
@davidjamesstone davidjamesstone force-pushed the feature/398642-post-submission-guidance branch from bda9b4d to 30e8af8 Compare September 16, 2024 13:57
@davidjamesstone davidjamesstone force-pushed the feature/398642-post-submission-guidance branch from 227b7fa to 25595ac Compare September 18, 2024 08:22
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@colinrotherham colinrotherham self-requested a review September 19, 2024 14:10
@davidjamesstone davidjamesstone merged commit 2b8b629 into main Sep 19, 2024
9 of 10 checks passed
@davidjamesstone davidjamesstone deleted the feature/398642-post-submission-guidance branch September 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants