Edit form contact details

[davidjamesstone]

[colinrotherham]

This is ace work @davidjamesstone

Some minor comments, see what you think

[colinrotherham]

I'm a bit worried how much we're sharing sessionNames.validationFailure

You could potentially submit a form in one form and see the errors in another (separate tab)

Should we keep the same name, but use a nested object keyed by route name?

[alexluckett]

This is a really good point. Future improvement?

[colinrotherham]

If you're not a fan of coercing everything to HTMLInputElement, have you seen this?

Suggested change

	expect(address?.value).toBe('[email protected]')
	expect(address).toHaveValue('[email protected]')

Although, can we start switching to ByRole queries so we're testing labels + hints at the same time?

I've been following the $XXX syntax for queried elements that GOV.UK Frontend uses too:

Suggested change

	expect(address?.value).toBe('[email protected]')
	const $address = screen.getByRole('textbox', {
	name: 'Email address',
	description: 'XXX'
	})
	expect($address).toHaveValue('[email protected]')

[davidjamesstone]

Resolved with 50f25b4

[colinrotherham]

Nice one @davidjamesstone

What about the ByRole queries?

We're currently using field IDs but "role" queries also test if labels/hints etc are wired up too

[sonarqubecloud]

Quality Gate failed

Failed conditions
7.8% Duplication on New Code (required ≤ 3%)
2 New Critical Issues (required ≤ 0)
3 New Major Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[colinrotherham]

I'll add a fix to my code coverage PR, but there was a compiler error in this one:

> [email protected] lint:types
> tsc --build tsconfig.json

designer/server/src/routes/forms/create.js(326,3): error TS2322: Type '{ createForm: "createFormValidationFailure"; privacyNotice: "privacyNoticeValidationFailure"; contactEmail: "contactEmailValidationFailure"; contactPhone: "contactPhoneValidationFailure"; contactOnline: "contactOnlineValidationFailure"; }' is not assignable to type '"create" | "redirectTo" | "fileDownloadValidationFailure" | "successNotification" | "errorList" | "validationFailure" | undefined'.
designer/server/src/routes/forms/api.js(62,23): error TS2345: Argument of type '{ createForm: "createFormValidationFailure"; privacyNotice: "privacyNoticeValidationFailure"; contactEmail: "contactEmailValidationFailure"; contactPhone: "contactPhoneValidationFailure"; contactOnline: "contactOnlineValidationFailure"; }' is not assignable to parameter of type 'string'.

[colinrotherham]

Fixed in commit range