Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike/update model configuration #3802

Merged
merged 43 commits into from
Jun 11, 2024
Merged

Spike/update model configuration #3802

merged 43 commits into from
Jun 11, 2024

Conversation

dvince2
Copy link
Collaborator

@dvince2 dvince2 commented Jun 7, 2024

Description

Resolves #(issue)

dvince2 added 30 commits May 29, 2024 14:10
@dvince2
Updating the current ModelConfiguration class to be `ModelConfigura…
c6f5e62 
…tionLegacy` so that we can work with `ModelConfiguration` without issue.
@dvince2
Adding POJOs for our model config typing as well as the generated typ…
183a52d 
…escript
@dvince2
More legacy renaming.
879a5f8
@dvince2
Service and Repository
a727c7a
@dvince2
Database entity prep
93d0609
@dvince2
Changing endpoints. More renaming to legacy
9da19c4
@dvince2
New controller
0be46d9
@dvince2
Merge remote-tracking branch 'origin/main' into spike/update-model-co…
efd780c 
…nfiguration
@dvince2
Creating model configs
8593a79
@dvince2
Merging main
2d7e78e
@dvince2
Updating model config
99e7adf
@dvince2
delete model config
467f0c9
@dvince2
Updaing front end to use legacy while this is transfered
5d880c1
@dvince2
Front end model configuration service
f61758c
@dvince2
merging main
bcf0a60
@dvince2
merging main
a714ec2
@dvince2
Merging main
43c0279
@dvince2
Merge remote-tracking branch 'origin/main' into spike/update-model-co…
ace64de 
…nfiguration
@dvince2
generating types
cb333da
@dvince2
leg work on endpoint
8c70378
@dvince2
Merge remote-tracking branch 'origin/main' into spike/update-model-co…
721021e 
…nfiguration
@dvince2
Merge remote-tracking branch 'origin/main' into spike/update-model-co…
6c293ad 
…nfiguration
@dvince2
fixing relations
dbc08e0
@dvince2
Stuffing values for front end
4a25160
@dvince2
Merge remote-tracking branch 'origin/main' into spike/update-model-co…
7ce19fb 
…nfiguration
@dvince2
generated types
87d89d4
@dvince2
Removing unused properties
bcb9676
@dvince2
Merge remote-tracking branch 'origin/main' into spike/update-model-co…
1d27648 
…nfiguration
@dvince2
Correct casing
5eba212
@dvince2
Merging main
458d1c9
@dvince2 dvince2 requested a review from mwdchang as a code owner June 7, 2024 18:54
@dvince2 dvince2 linked an issue Jun 7, 2024 that may be closed by this pull request
[TASK]: Update Model Configuration #3507
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Please review the checklist

  • server error messages use messages.properties
  • manual test and/or scenario test updated, if not sure ask #askem-testing
  • documentation updated
  • breaking change notify #askem-engineering

This was referenced Jun 7, 2024
Merged
Merged
Merged
@blanchco
Copy link
Contributor

blanchco commented Jun 7, 2024 •
edited
Loading

Might be cause its late on a Friday, I checked this branch out and have been having troubles creating a new ModelConfiguration (the new one). Perhaps we can chat Monday and you could help me out?

YohannParis
YohannParis reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the upload of a model file creating a model and a model configuration done in another PR?

...e/uncharted/terarium/hmiserver/controller/simulationservice/SimulationRequestController.java Show resolved Hide resolved
...uncharted/terarium/hmiserver/models/dataservice/model/configurations/ModelConfiguration.java Outdated Show resolved Hide resolved
...uncharted/terarium/hmiserver/models/dataservice/model/configurations/ModelConfiguration.java Show resolved Hide resolved
.../main/java/software/uncharted/terarium/hmiserver/service/data/ModelConfigurationService.java Show resolved Hide resolved
.../main/java/software/uncharted/terarium/hmiserver/controller/dataservice/ModelController.java Show resolved Hide resolved
.../main/java/software/uncharted/terarium/hmiserver/controller/dataservice/ModelController.java Show resolved Hide resolved
.../uncharted/terarium/hmiserver/controller/dataservice/ModelConfigurationLegacyController.java Outdated Show resolved Hide resolved
@dvince2 dvince2 requested review from YohannParis and mwdchang June 11, 2024 13:20
@dvince2 dvince2 merged commit 5a6e965 into main Jun 11, 2024
9 checks passed
@dvince2 dvince2 deleted the spike/update-model-configuration branch June 11, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: Update Model Configuration
4 participants
@dvince2 @blanchco @YohannParis @mwdchang