Function to create an AMR model structure from model configuration #3811
Conversation
…vice-endpoints-for-old-model-configurations-schema
…vice-endpoints-for-old-model-configurations-schema
...ftware/uncharted/terarium/hmiserver/controller/dataservice/ModelConfigurationController.java
Outdated
Show resolved
Hide resolved
...ftware/uncharted/terarium/hmiserver/controller/dataservice/ModelConfigurationController.java
Show resolved
Hide resolved
blanchco
changed the title
...uncharted/terarium/hmiserver/models/dataservice/model/configurations/ObservableSemantic.java
Show resolved
Hide resolved
| updateModelParameters( | ||
| model.get().getParameters(), modelConfiguration.get().getParameterSemanticList()); | ||
| updateModelInitials( | ||
| model.get().getInitials(), modelConfiguration.get().getInitialSemanticList()); | ||
| updateModelObservables(model.get().getObservables(), modelConfiguration.get().getObservableSemanticList()); |
There was a problem hiding this comment.
Why are we using update instead of set here?
A model-configuration should match the model that is tied to the modelId so there is no reasons to do some matching of information here? Or I am missing something?
There was a problem hiding this comment.
Ill rename the function to set instead of update.
This jist of these functions are to set the semantics in an AMR structure from the model it is derived from. The model semantics would have additional properties that we do not get from a model configuration (i.e. name, description, concept...). I am just simply setting the certain properties that we have in the model configuration to the model (value, distribution, expression...).
There was a problem hiding this comment.
@YohannParis fyi it isn't super clear that the config will match the model exactly, you may have extra observables and I don't think we have made it clear where observables should be defined. May be worth to clear up after the 1st around.
…' into 3759-add-ta3-service-endpoints-for-old-model-configurations-schema
blanchco
deleted the
3759-add-ta3-service-endpoints-for-old-model-configurations-schema
branch
Description
Resolves #(issue)