880 change Holder::foreach() to return void #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstrzebonski
changed the title
jstrzebonski
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #993 +/- ##
===========================================
- Coverage 77.41% 77.35% -0.06%
===========================================
Files 656 656
Lines 25160 25109 -51
===========================================
- Hits 19477 19424 -53
- Misses 5683 5685 +2
|
PhilMiller
approved these changes
Aug 19, 2020
lifflander
approved these changes
Aug 19, 2020
|
@jstrzebonski You need to get commit signing with GPG turned on. You can't merge unless Github has your verified signature. |
jstrzebonski
force-pushed
the
880-return-void-from-collection-holder-foreach
branch
2 times, most recently
from
b4a31d6 to
c738a36
Compare
|
@lifflander Commit is verified and branch is rebased. |
lifflander
force-pushed
the
880-return-void-from-collection-holder-foreach
branch
from
c738a36 to
511a5b1
Compare
bradybray
approved these changes
Aug 21, 2020
jstrzebonski
deleted the
880-return-void-from-collection-holder-foreach
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIS returning bool from
Holder::foraech(FuncApplyType fn)is redundant.FuncApplyTypeis returning void, so I don't see howforeach()might return false / failed (except for throwing, but I'm not sure if that's even possible).Fixes #880