Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollectionHolder foreach should return void #880

Closed
lifflander opened this issue Jun 21, 2020 · 0 comments · Fixed by #993
Closed

CollectionHolder foreach should return void #880

lifflander opened this issue Jun 21, 2020 · 0 comments · Fixed by #993
Assignees
@jstrzebonski
Labels
intro A potentially good introductory issue for a new developer to address type: task

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

The CollectionHolder foreach method returns a boolean that is useless and potentially confusing. Make it return void unless there is some use for a return value, in that case make it work and document it.
@lifflander lifflander mentioned this issue Jun 21, 2020
Merged
@PhilMiller PhilMiller added the intro A potentially good introductory issue for a new developer to address label Jul 23, 2020
@lifflander lifflander mentioned this issue Aug 18, 2020
Open
jstrzebonski pushed a commit that referenced this issue Aug 18, 2020
#880: change Holder::foreach() to return void
27e83cd
@jstrzebonski jstrzebonski mentioned this issue Aug 18, 2020
Merged
@jstrzebonski jstrzebonski linked a pull request Aug 18, 2020 that will close this issue
880 change Holder::foreach() to return void #993
Merged
jstrzebonski pushed a commit that referenced this issue Aug 19, 2020
#880: change Holder::foreach() to return void
b4a31d6
jstrzebonski pushed a commit that referenced this issue Aug 19, 2020
#880: change Holder::foreach() to return void
c738a36
lifflander pushed a commit that referenced this issue Aug 20, 2020
@lifflander
#880: change Holder::foreach() to return void
511a5b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstrzebonski jstrzebonski

Labels
intro A potentially good introductory issue for a new developer to address type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

880 change Holder::foreach() to return void DARMA-tasking/vt
3 participants
@PhilMiller @lifflander @jstrzebonski