Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2063: Convert buffer pointers to std::byte* #2253

Merged
merged 23 commits into from
Apr 16, 2024
Merged

#2063: Convert buffer pointers to std::byte* #2253

merged 23 commits into from
Apr 16, 2024

Conversation

thearusable
Copy link
Contributor

Closes #2063

@thearusable thearusable self-assigned this Mar 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(202): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich)

Build for 463661b (2024-04-12 09:00:10 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Testing - passed

Build log

@thearusable thearusable force-pushed the 2063-convert-buffer-pointers-to-std-byte branch from 81a494e to 2a8ffcd Compare March 14, 2024 15:18
@thearusable thearusable marked this pull request as ready for review March 22, 2024 15:20
@thearusable thearusable force-pushed the 2063-convert-buffer-pointers-to-std-byte branch from 17c5f48 to 71190e2 Compare March 22, 2024 15:26
@thearusable thearusable force-pushed the 2063-convert-buffer-pointers-to-std-byte branch 2 times, most recently from 2802215 to e47b78d Compare March 27, 2024 10:35
lifflander
lifflander approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@thearusable
#2063: Update char* to std::byte* in pool_header
447a129
@thearusable
#2063: Update char* to std::byte* in ActiveMessenger objects
d7b1423
@thearusable
#2063: Update void* to std::byte* in ActiveMessenger
58d3f53
@thearusable
#2063: Update void* to std::byte* in Pool
0b82273
@thearusable
#2063: Update void* to std::byte* in MemoryPool
eca26b5
@thearusable
#2063: Remove unnecessary casts
d50b1a2
@thearusable
#2063: Update RDMA_PtrType to std::byte*
c9f646e
@thearusable
#2063: Update void* to std::byte* in Payload Envelope
7ef97cb
@thearusable
#2063: Update void* to std::byte* in smart_ptr
06c4933
@thearusable
#2063: Update void* to std::byte* in PipeState
a635b6a
@thearusable
#2063: Update RDMA_RecvType to accept std::byte*
70cc839
@thearusable
#2063: Update void* to std::byte* in Holder struct
2ba3922
@thearusable
#2063: Update void* to std::byte* in runnable
c492dd8
@thearusable
#2063: Update void* to std::byte* in ObjGroupManager
10835a8
@thearusable
#2063: Update void* to std::byte* in DispatchCollection
5670b01
@thearusable
#2063: Update void* to std::byte* in scatter
230c425
@thearusable
#2063: Update void* to std::byte* in collection
f5757c2
@thearusable
#2063: Update void* to std::byte* in HolderUser
ad45159
@thearusable
#2063: Update void* in pipe manager
c20de23
@thearusable thearusable force-pushed the 2063-convert-buffer-pointers-to-std-byte branch from e47b78d to 463661b Compare April 12, 2024 09:00
@lifflander lifflander merged commit 084c6c3 into develop Apr 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander lifflander approved these changes

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@nlslatt nlslatt Awaiting requested review from nlslatt

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert buffer pointers to std::byte*
2 participants
@thearusable @lifflander