Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert buffer pointers to std::byte* #2063

Closed
PhilMiller opened this issue Jan 13, 2023 · 0 comments · Fixed by #2253
Closed

Convert buffer pointers to std::byte* #2063

PhilMiller opened this issue Jan 13, 2023 · 0 comments · Fixed by #2253
Assignees
@thearusable
Labels
c++17 Things to be done once we can rely on C++17 support type: task

Comments

@PhilMiller
Copy link
Member

What Needs to be Done?

C++17 has a safe-ish vocabulary type std::byte for referring to objects/object representations that should not be operated on except as uninterpreted bits/bytes. We ought to adopt it.

Is your feature request related to a problem? Please describe.

Describe potential solution outcome

Describe alternatives you've considered

Additional context
@PhilMiller PhilMiller added type: task c++17 Things to be done once we can rely on C++17 support labels Jan 13, 2023
thearusable added a commit that referenced this issue Mar 13, 2024
@thearusable
#2063: Update char* to std::byte* in pool_header
32ec787
thearusable added a commit that referenced this issue Mar 13, 2024
@thearusable
#2063: Update char* to std::byte* in ActiveMessenger objects
44ae615
thearusable added a commit that referenced this issue Mar 13, 2024
@thearusable
#2063: Update void* to std::byte* in ActiveMessenger
92f0da2
thearusable added a commit that referenced this issue Mar 13, 2024
@thearusable
#2063: Update void* to std::byte* in Pool
3eeefa1
@thearusable thearusable mentioned this issue Mar 13, 2024
Merged
thearusable added a commit that referenced this issue Mar 14, 2024
@thearusable
#2063: Update void* to std::byte* in MemoryPool
00021cc
thearusable added a commit that referenced this issue Mar 14, 2024
@thearusable
#2063: Remove unnecessary casts
b06b610
thearusable added a commit that referenced this issue Mar 14, 2024
@thearusable
#2063: Update RDMA_PtrType to std::byte*
5de2143
thearusable added a commit that referenced this issue Mar 14, 2024
@thearusable
#2063: Update void* to std::byte* in Payload Envelope
81a494e
thearusable added a commit that referenced this issue Mar 14, 2024
@thearusable
#2063: Update RDMA_PtrType to std::byte*
919688d
thearusable added a commit that referenced this issue Mar 14, 2024
@thearusable
#2063: Update void* to std::byte* in Payload Envelope
2a8ffcd
thearusable added a commit that referenced this issue Mar 15, 2024
@thearusable
#2063: Update void* to std::byte* in smart_ptr
91f122a
thearusable added a commit that referenced this issue Mar 15, 2024
@thearusable
#2063: Update void* to std::byte* in PipeState
7fe9e0c
thearusable added a commit that referenced this issue Mar 15, 2024
@thearusable
#2063: Update RDMA_RecvType to accept std::byte*
baa338a
thearusable added a commit that referenced this issue Mar 15, 2024
@thearusable
#2063: Update void* to std::byte* in Holder struct
8d5b2a8
thearusable added a commit that referenced this issue Mar 19, 2024
@thearusable
#2063: Update void* to std::byte* in runnable
6d2c0cf
thearusable added a commit that referenced this issue Mar 19, 2024
@thearusable
#2063: Update void* to std::byte* in ObjGroupManager
686db79
thearusable added a commit that referenced this issue Mar 19, 2024
@thearusable
#2063: Update void* to std::byte* in DispatchCollection
646622b
thearusable added a commit that referenced this issue Mar 19, 2024
@thearusable
#2063: Update void* to std::byte* in scatter
70f7aab
thearusable added a commit that referenced this issue Mar 19, 2024
@thearusable
#2063: Update void* to std::byte* in collection
a908cba
thearusable added a commit that referenced this issue Mar 19, 2024
@thearusable
#2063: Update void* to std::byte* in HolderUser
e954b74
thearusable added a commit that referenced this issue Mar 19, 2024
@thearusable
#2063: Update void* in pipe manager
07cd894
thearusable added a commit that referenced this issue Mar 19, 2024
@thearusable
#2063: Update void* to std::byte(
5dc3357
thearusable added a commit that referenced this issue Mar 22, 2024
@thearusable
#2063: Update char* to std::byte* in Scatter
6d47792
thearusable added a commit that referenced this issue Mar 22, 2024
@thearusable
#2063: Update void* to std::byte* in auto registry
2b6b3ca
thearusable added a commit that referenced this issue Mar 22, 2024
@thearusable
#2063: Clean up casts
17c5f48
thearusable added a commit that referenced this issue Mar 22, 2024
@thearusable
#2063: Update void* to std::byte*
d557158
thearusable added a commit that referenced this issue Apr 12, 2024
@thearusable
#2063: Update void* in pipe manager
c20de23
thearusable added a commit that referenced this issue Apr 12, 2024
@thearusable
#2063: Update void* to std::byte*
5c1e2e9
thearusable added a commit that referenced this issue Apr 12, 2024
@thearusable
#2063: Update char* to std::byte* in Scatter
5207a52
thearusable added a commit that referenced this issue Apr 12, 2024
@thearusable
#2063: Update void* to std::byte* in auto registry
2f0d87c
thearusable added a commit that referenced this issue Apr 12, 2024
@thearusable
#2063: Clean up casts
463661b
lifflander added a commit that referenced this issue Apr 16, 2024
@lifflander
Merge pull request #2253 from DARMA-tasking/2063-convert-buffer-point…
084c6c3 
…ers-to-std-byte

#2063: Convert buffer pointers to `std::byte*`
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update char* to std::byte* in pool_header
c66d6e5
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update char* to std::byte* in ActiveMessenger objects
4600cbc
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in ActiveMessenger
238c00d
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in Pool
d8bf238
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in MemoryPool
f36c4f5
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Remove unnecessary casts
ecb566b
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update RDMA_PtrType to std::byte*
2c82ae0
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in Payload Envelope
6b583e1
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in smart_ptr
53cf434
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in PipeState
8c2afed
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update RDMA_RecvType to accept std::byte*
281cf47
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in Holder struct
e50d919
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in runnable
07a54f6
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in ObjGroupManager
542efc3
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in DispatchCollection
31741a3
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in scatter
de8f55c
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in collection
e06f058
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in HolderUser
de8ea8c
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* in pipe manager
ed38fdd
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte*
9f2defc
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update char* to std::byte* in Scatter
f79d641
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Update void* to std::byte* in auto registry
e6d8236
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2063: Clean up casts
23488ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearusable thearusable

Labels
c++17 Things to be done once we can rely on C++17 support type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2063: Convert buffer pointers to std::byte* DARMA-tasking/vt
2 participants
@PhilMiller @thearusable