Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2229: Add attributes field for rank and object #2231

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

thearusable
Copy link
Contributor

Closes #2229

@thearusable thearusable self-assigned this Dec 22, 2023
Copy link

github-actions bot commented Dec 22, 2023

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(202): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich)

Build for 81d91e0 (2024-02-22 22:51:20 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Testing - passed

Build log


@thearusable thearusable force-pushed the 2229-add-arbitrary-attributes-to-json-validator branch from 0001904 to 14b12dc Compare December 22, 2023 17:04
@thearusable thearusable marked this pull request as ready for review December 22, 2023 17:04
@thearusable thearusable force-pushed the 2229-add-arbitrary-attributes-to-json-validator branch from 14b12dc to cddf369 Compare December 29, 2023 11:40
@thearusable thearusable marked this pull request as draft January 2, 2024 17:54
@thearusable thearusable force-pushed the 2229-add-arbitrary-attributes-to-json-validator branch from cddf369 to 14b12dc Compare January 3, 2024 15:26
@pierrepebay
Copy link
Contributor

For reference: DARMA-tasking/vt-tv#44 presents what could be included in these new attribute fields.

@thearusable thearusable force-pushed the 2229-add-arbitrary-attributes-to-json-validator branch 3 times, most recently from 1a76186 to 5a940b7 Compare February 16, 2024 15:04
@thearusable thearusable marked this pull request as ready for review February 16, 2024 17:21
@lifflander lifflander force-pushed the 2229-add-arbitrary-attributes-to-json-validator branch from 5a940b7 to 01039e3 Compare February 20, 2024 20:18
@lifflander
Copy link
Collaborator

lifflander commented Feb 22, 2024

@thearusable The pipeline that runs the schema validator on the JSON produced from VT is failing. Something must be wrong in the specification? The specification looks fine, but this is the error:

Running schema validator on: ./tests/vt_lb_data/data.1.json.br
Validating file: /build/vt/tests/vt_lb_data/data.1.json.br
Invalid JSON schema in /build/vt/tests/vt_lb_data/data.1.json.br
[JSON_data_files_validator] SchemaError Key 'metadata' error:
Key 'attributes' error:
None should be instance of 'dict'
+ echo 'Invalid schema in ./tests/vt_lb_data/data.1.json.br.. exiting'
Invalid schema in ./tests/vt_lb_data/data.1.json.br.. exiting

@JacobDomagala
Copy link
Contributor

@lifflander Updated, should be fine now.

@thearusable
Copy link
Contributor Author

@lifflander Updated, should be fine now.

Thanks! @JacobDomagala

@lifflander lifflander merged commit f3ae30a into develop Feb 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend JSON files to include user-defined attributes per rank and object
4 participants