#2229: Rename get method for phase attributes

DARMA-tasking · Feb 16, 2024 · 5a940b7 · 5a940b7
1 parent a621055
commit 5a940b7
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/vt/vrt/collection/balance/lb_data_holder.cc b/src/vt/vrt/collection/balance/lb_data_holder.cc
@@ -176,7 +176,7 @@ std::unique_ptr<nlohmann::json> LBDataHolder::toJson(PhaseType phase) const {
             } else if (std::holds_alternative<std::string>(value)) {
               j["tasks"][i]["attributes"][key] = std::get<std::string>(value);
             }
-          }          
+          }
         }
       }
 

diff --git a/src/vt/vrt/collection/balance/node_lb_data.cc b/src/vt/vrt/collection/balance/node_lb_data.cc
@@ -103,7 +103,7 @@ NodeLBData::getUserData() const {
 }
 
 std::unordered_map<PhaseType, DataMapType> const*
-NodeLBData::getUserAttributes() const {
+NodeLBData::getPhaseAttributes() const {
   return &lb_data_->node_user_attributes_;
 }
 

diff --git a/src/vt/vrt/collection/balance/node_lb_data.h b/src/vt/vrt/collection/balance/node_lb_data.h
@@ -193,7 +193,7 @@ struct NodeLBData : runtime::component::Component<NodeLBData> {
    *
    * \return an observer pointer to the user-defined attributes
    */
-  std::unordered_map<PhaseType, DataMapType> const* getUserAttributes() const;
+  std::unordered_map<PhaseType, DataMapType> const* getPhaseAttributes() const;
 
   /**
    * \internal \brief Get stored object comm data for a specific phase

diff --git a/src/vt/vrt/collection/types/storage/storable.impl.h b/src/vt/vrt/collection/types/storage/storable.impl.h
@@ -68,7 +68,7 @@ void Storable::valInsert(std::string const& str, U&& u) {
 
 template <typename U>
 void Storable::valInsert(
-  std::string const& str, U&& u, bool dump_to_json, bool provide_to_lb, bool dump_to_attributes 
+  std::string const& str, U&& u, bool dump_to_json, bool provide_to_lb, bool dump_to_attributes
 ) {
   map_.emplace(
     std::piecewise_construct,

diff --git a/tests/unit/collection/test_lb.extended.cc b/tests/unit/collection/test_lb.extended.cc
@@ -810,7 +810,7 @@ TEST_P(TestDumpAttributesFieldData, test_dump_attributes_json) {
       elm_ptr->valInsert("intSample", 123, false, false, is_attribute);
       elm_ptr->valInsert("doubleSample", 123.456, false, false, is_attribute);
       elm_ptr->valInsert("stringSample", std::string("abc"), false, false, is_attribute);
-      
+
       elm_ptr->collectAttributes(
         [&](std::string const& key, auto val) {
           lbdh.node_user_attributes_[phase][elm_id][key] = val->toVariant();
-Original file line number
+Diff line change
@@ Expand Up @@
                 } else if (std::holds_alternative<std::string>(value)) {
                   j["tasks"][i]["attributes"][key] = std::get<std::string>(value);
                 }
-              }
+              }
             }
           }
@@ Expand Down @@