Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2107: CI: remove builds for unsupported compilers #2110

Merged
merged 6 commits into from
Mar 30, 2023
Merged

#2107: CI: remove builds for unsupported compilers #2110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23e7d94
#2107: CI: remove gcc-7 build
cz4rs Mar 27, 2023
3eb78d9
#2107: CI: update README and build names
cz4rs Mar 27, 2023
56cef27
#2107: CI: update cache name in macos build
cz4rs Mar 30, 2023
1902ab1
#2107: CI: update trigger conditions
cz4rs Mar 30, 2023
42f0ce3
#2107: CI: further remove gcc-7 usage
cz4rs Mar 30, 2023
7eaac98
#2107: CI: use pinned version of macos image (12)
cz4rs Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
REPO=lifflander1/vt
ARCH=amd64
UBUNTU=18.04
UBUNTU=22.04
ULIMIT_CORE=0
COMPILER=gcc-7
COMPILER=gcc-12
COMPILER_TYPE=gnu
PROXY=
CACHE=
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
ARCH: amd64
UBUNTU: 18.04
COMPILER_TYPE: gnu
COMPILER: gcc-7
COMPILER: gcc-8
PhilMiller marked this conversation as resolved.
Show resolved Hide resolved
BUILD_TYPE: release
ULIMIT_CORE: 0
VT_LB: 1
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/macosx-clang-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: PR tests (clang-8, macosx, mpich)
name: PR tests (clang-14, macosx, mpich)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache name and maybe other stuff still refer to clang 8. I don't see what in this file actually set the compiler version, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the version number everywhere.

Compiler version is not set explicitly, we use the default for that image: https://github.com/actions/runner-images/blob/macOS-12/20230318.1/images/macos/macos-12-Readme.md.


# Trigger the workflow on push or pull request
on:
push:
branches:
- develop
- 1.*
- main
pull_request:
types: [opened, reopened, synchronize, converted_to_draft, ready_for_review]

Expand All @@ -15,7 +15,7 @@ concurrency:

jobs:
build:
runs-on: macos-latest
runs-on: macos-12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing latest to a pinned version (this was considered preferable for Intel compilers, we can probably use the same approach here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this should be enough to make the compiler version pinned as well, so we don't have to configure it explicitly elsewhere.


if: github.event.pull_request.draft == false

Expand All @@ -36,14 +36,14 @@ jobs:
- uses: actions/cache@v3
with:
path: ~/.ccache
key: ${{ runner.os }}-macosx-clang-8-ccache-${{ secrets.GH_ACTIONS_CACHE_VERSION }}-${{ hashFiles('**/*') }}
key: ${{ runner.os }}-macosx-clang-14-ccache-${{ secrets.GH_ACTIONS_CACHE_VERSION }}-${{ hashFiles('**/*') }}
restore-keys: |
${{ runner.os }}-macosx-clang-8-ccache-${{ secrets.GH_ACTIONS_CACHE_VERSION }}
${{ runner.os }}-macosx-clang-14-ccache-${{ secrets.GH_ACTIONS_CACHE_VERSION }}
- uses: actions/cache@v3
id: mpich-cache
with:
path: ~/.mpich
key: ${{ runner.os }}-macosx-clang-8-mpich-${{ hashFiles('**/.github/workflows/macosx-clang-mpich.yml', '**/ci/deps/mpich.sh') }}
key: ${{ runner.os }}-macosx-clang-14-mpich-${{ hashFiles('**/.github/workflows/macosx-clang-mpich.yml', '**/ci/deps/mpich.sh') }}
- name: Install Dependencies
shell: bash
run: brew bundle --file=ci/Brewfile
Expand Down
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@
[![codecov](https://codecov.io/gh/DARMA-tasking/vt/branch/develop/graph/badge.svg)](https://codecov.io/gh/DARMA-tasking/vt)
[![License](https://img.shields.io/badge/License-BSD%203--Clause-orange.svg)](https://opensource.org/licenses/BSD-3-Clause)
![](https://github.com/DARMA-tasking/vt/workflows/Docker%20Image%20CI/badge.svg)
[![gcc-7, ubuntu, mpich, trace runtime, LB](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-7%2C%20ubuntu%2C%20mpich%2C%20trace%20runtime%2C%20LB)?branchName=develop&Label=(gcc-7%2C%20ubuntu%2C%20mpich%2C%20trace%20runtime%2C%20LB))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=8&branchName=develop)
[![gcc-8, ubuntu, mpich, address sanitizer](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-8%2C%20ubuntu%2C%20mpich%2C%20address%20sanitizer)?branchName=develop&Label=(gcc-8%2C%20ubuntu%2C%20mpich%2C%20address%20sanitizer))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=9&branchName=develop)
[![gcc-9, ubuntu, mpich, zoltan](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-9%2C%20ubuntu%2C%20mpich%2C%20zoltan)?branchName=develop&Label=(gcc-9%2C%20ubuntu%2C%20mpich%2C%20zoltan))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=10&branchName=develop)
[![gcc-10, ubuntu, openmpi, no LB](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-10%2C%20ubuntu%2C%20openmpi%2C%20no%20LB)?branchName=develop&Label=(gcc-10%2C%20ubuntu%2C%20openmpi%2C%20no%20LB))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=4&branchName=develop)
[![gcc-11, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-11%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(gcc-11%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=29&branchName=develop)
[![gcc-11, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-11%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(gcc-11%2C%20ubuntu%2C%20mpich%2C%20trace%20runtime%2C%20coverage))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=29&branchName=develop)
[![gcc-12, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(gcc-12%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(gcc-12%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=30&branchName=develop)
[![clang-9, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(clang-9%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(clang-9.0%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=22&branchName=develop)
[![clang-10, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(clang-10%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(clang-10.0%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=21&branchName=develop)
Expand All @@ -21,7 +20,7 @@
[![nvidia cuda 11.2, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(nvidia%20cuda%2011.2%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(nvidia%20cuda%2011.2%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=32&branchName=develop)
[![gcc-10, ubuntu, openmpi, no LB, spack-package](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20spack-package%20(gcc-10%2C%20ubuntu%2C%20openmpi%2C%20no%20LB%2C%20spack-package)?branchName=develop&Label=(gcc-10%2C%20ubuntu%2C%20openmpi%2C%20no%20LB%2C%20spack-package))](https://dev.azure.com/DARMA-tasking/DARMA/_build/latest?definitionId=20&branchName=develop)
[![icpx, ubuntu, mpich](https://dev.azure.com/DARMA-tasking/DARMA/_apis/build/status/PR%20tests%20(intel%20icpx%2C%20ubuntu%2C%20mpich)?branchName=develop&Label=(icpx%2C%20ubuntu%2C%20mpich))](https://dev.azure.com/DARMA-tasking/DARMA/_build?definitionId=24&branchName=develop)
![apple clang, macosx, mpich](https://github.com/DARMA-tasking/vt/workflows/PR%20tests%20(clang-8,%20macosx,%20mpich)/badge.svg?branch=develop)
![apple clang, macosx, mpich](https://github.com/DARMA-tasking/vt/workflows/PR%20tests%20(clang-14,%20macosx,%20mpich)/badge.svg?branch=develop)
![Build Documentation](https://github.com/DARMA-tasking/vt/workflows/Build%20Documentation/badge.svg?branch=develop)
[![](https://github.com/DARMA-tasking/vt/wiki/build_stats/build_status_badge.svg)](https://github.com/DARMA-tasking/vt/wiki/Build-Stats)

Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-clang-10-ubuntu-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-clang-11-ubuntu-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-clang-12-ubuntu-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-clang-13-ubuntu-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-clang-14-ubuntu-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-clang-9-ubuntu-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-clang-alpine-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-gcc-10-ubuntu-openmpi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand Down
20 changes: 10 additions & 10 deletions ci/azure/azure-gcc-11-ubuntu-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
############## Warning this is a generated file---do not modify ###############
###############################################################################

name: PR tests (gcc-11, ubuntu, mpich, json schema test)
name: PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: false
Expand All @@ -30,10 +30,10 @@ variables:
COMPILER: gcc-11
BUILD_TYPE: release
ULIMIT_CORE: 0
CODE_COVERAGE: 0
CODE_COVERAGE: 1
VT_LB: 1
VT_TRACE: 0
VT_TRACE_RT: 0
VT_TRACE: 1
VT_TRACE_RT: 1
VT_TRACE_ONLY: 1
VT_MIMALLOC: 0
VT_DOCS: 0
Expand All @@ -43,7 +43,7 @@ variables:
VT_POOL: 1
VT_EXTENDED_TESTS: 1
VT_TESTS_NUM_NODES: 2
VT_UNITY_BUILD: 1
VT_UNITY_BUILD: 0
VT_PRODUCTION_BUILD: 0
VT_FCONTEXT: 0
VT_ZOLTAN: 0
Expand All @@ -53,7 +53,7 @@ variables:
VT_BUILD_SHARED_LIBS: 0
VT_INCLUSION: TPL
CMAKE_CXX_STANDARD: 17
TEST_LB_SCHEMA: 1
TEST_LB_SCHEMA: 0
CACHE: "$(Agent.TempDirectory)/cache/"
cache_name: ubuntu-gcc-11-cache
build_root: "$(CACHE)/$(ARCH)-ubuntu-$(UBUNTU)-$(COMPILER)-cache/"
Expand Down Expand Up @@ -132,14 +132,14 @@ stages:
containerregistrytype: 'Container Registry'
dockerComposeFile: '**/docker-compose.yml'
action: 'Run a Docker Compose command'
dockerComposeCommand: '$(compose_command) ubuntu-cpp-clean'
dockerComposeCommand: '$(compose_command) ubuntu-cpp-clean-noinstall'
- task: DockerCompose@0
displayName: Build container
inputs:
containerregistrytype: 'Container Registry'
dockerComposeFile: '**/docker-compose.yml'
action: 'Run a Docker Compose command'
dockerComposeCommand: 'run ubuntu-cpp-clean'
dockerComposeCommand: 'run ubuntu-cpp-clean-noinstall'
env:
CODECOV_TOKEN: $(codecov_token)
- task: Bash@3
Expand Down Expand Up @@ -170,7 +170,7 @@ stages:
dockerRegistryEndpoint: 'dockerRegistryConnection1'
dockerComposeFile: '**/docker-compose.yml'
action: 'Run a Docker Compose command'
dockerComposeCommand: 'push ubuntu-cpp-clean'
dockerComposeCommand: 'push ubuntu-cpp-clean-noinstall'
- task: Bash@3
displayName: Create artifacts
continueOnError: true
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/azure-gcc-12-ubuntu-mpich.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trigger:
branches:
include:
- develop
- 1.0.0*
- main

pr:
drafts: true
Expand Down
Loading