Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2107: CI: remove builds for unsupported compilers #2110

Merged
merged 6 commits into from
Mar 30, 2023
Merged

#2107: CI: remove builds for unsupported compilers #2110

merged 6 commits into from
Mar 30, 2023

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Mar 21, 2023 •
edited
Loading

  • remove build for gcc-7 (no longer supported)
  • move its configuration to gcc-11 build
  • move LB schema test to gcc-9 build (to avoid having too many options on gcc-11)

fixes #2107

@github-actions
Copy link

github-actions bot commented Mar 21, 2023 •
edited
Loading

Pipelines results

PR tests (clang-11, ubuntu, mpich, fcontext)

Build for 14db2b4 (2023-03-21 13:44:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 2ab7c9b (2023-03-21 12:07:29 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich, json schema test)

Build for 2ab7c9b (2023-03-21 12:07:29 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich, ubsan)

Build for 14db2b4 (2023-03-21 13:44:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich, trace)

Build for 14db2b4 (2023-03-21 13:44:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
in%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, LB)

Build for 14db2b4 (2023-03-21 13:44:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich, address sanitizer)

Build for 14db2b4 (2023-03-21 13:44:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 7eaac98 (2023-03-30 11:11:59 UTC)

Compilation - successful

Testing - passed

Build log

@cz4rs cz4rs force-pushed the 2107-remove-obsolete-builds branch from 2ab7c9b to 81b2a38 Compare March 21, 2023 12:21
@cz4rs cz4rs marked this pull request as draft March 21, 2023 17:37
@cz4rs
Copy link
Contributor Author

cz4rs commented Mar 21, 2023

FIXME: we actually support gcc-8.2, do not remove the corresponding build.

@nmm0 nmm0 mentioned this pull request Mar 21, 2023
Open
@cz4rs cz4rs marked this pull request as ready for review March 27, 2023 08:39
@cz4rs cz4rs force-pushed the 2107-remove-obsolete-builds branch from 14db2b4 to 7aa1cdf Compare March 27, 2023 08:49
PhilMiller
PhilMiller reviewed Mar 29, 2023
View reviewed changes
.github/workflows/macosx-clang-mpich.yml
@@ -1,4 +1,4 @@
name: PR tests (clang-8, macosx, mpich)
name: PR tests (clang-14, macosx, mpich)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache name and maybe other stuff still refer to clang 8. I don't see what in this file actually set the compiler version, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the version number everywhere.

Compiler version is not set explicitly, we use the default for that image: https://github.com/actions/runner-images/blob/macOS-12/20230318.1/images/macos/macos-12-Readme.md.

@cz4rs cz4rs force-pushed the 2107-remove-obsolete-builds branch 7 times, most recently from b197e4f to 7640b76 Compare March 30, 2023 10:46
@cz4rs cz4rs force-pushed the 2107-remove-obsolete-builds branch from 7640b76 to 7eaac98 Compare March 30, 2023 11:12
cz4rs
cz4rs commented Mar 30, 2023
View reviewed changes
.github/workflows/macosx-clang-mpich.yml
@@ -15,7 +15,7 @@ concurrency:

jobs:
build:
runs-on: macos-latest
runs-on: macos-12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing latest to a pinned version (this was considered preferable for Intel compilers, we can probably use the same approach here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this should be enough to make the compiler version pinned as well, so we don't have to configure it explicitly elsewhere.

@cz4rs cz4rs requested review from PhilMiller and lifflander March 30, 2023 13:01
@PhilMiller PhilMiller merged commit d4f4501 into develop Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@nmm0 nmm0 Awaiting requested review from nmm0

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@nlslatt nlslatt Awaiting requested review from nlslatt

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

@thearusable thearusable Awaiting requested review from thearusable

@lifflander lifflander Awaiting requested review from lifflander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove gcc-7 build and reproduce its configurations on different build
3 participants
@cz4rs @PhilMiller @lifflander