Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2002: Runnable: Rename begin()/end() to start()/finish() #2003

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

JacobDomagala
Copy link
Contributor

Fixes #2002

@JacobDomagala JacobDomagala self-assigned this Oct 28, 2022
@github-actions
Copy link

github-actions bot commented Oct 28, 2022

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-3.9, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-5, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-6, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-5.0, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for debc638 (2022-11-14 19:51:49 UTC)

Compilation - successful

Testing - passed

Build log


Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JacobDomagala JacobDomagala force-pushed the 2002-rename-begin-end-of-runnable branch from ddb5cae to 963f59b Compare November 8, 2022 18:21
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #2003 (fa55c93) into develop (47f6ce2) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head fa55c93 differs from pull request most recent head debc638. Consider uploading reports for the commit debc638 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2003      +/-   ##
===========================================
- Coverage    84.50%   84.50%   -0.01%     
===========================================
  Files          731      731              
  Lines        25860    25860              
===========================================
- Hits         21854    21852       -2     
- Misses        4006     4008       +2     
Impacted Files Coverage Δ
src/vt/phase/phase_manager.cc 91.21% <0.00%> (-1.36%) ⬇️

@JacobDomagala JacobDomagala force-pushed the 2002-rename-begin-end-of-runnable branch from 963f59b to 83cf57e Compare November 9, 2022 21:06
@JacobDomagala JacobDomagala force-pushed the 2002-rename-begin-end-of-runnable branch from 83cf57e to debc638 Compare November 14, 2022 19:51
@lifflander lifflander merged commit 89d29ca into develop Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename begin/end to something like start/finish
4 participants