Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename begin/end to something like start/finish #2002

Closed
PhilMiller opened this issue Oct 25, 2022 · 0 comments · Fixed by #2003
Closed

Rename begin/end to something like start/finish #2002

PhilMiller opened this issue Oct 25, 2022 · 0 comments · Fixed by #2003
Assignees
@JacobDomagala

Comments

@PhilMiller
Copy link
Member

PhilMiller commented Oct 25, 2022 •
edited
Loading

Not relevant to this PR, but I realize that we should probably not have methods named begin/end that are unrelated to getting the relevant iterators of a container-like class. Perhaps we should consider renaming them to something like start/finish

Originally posted by @PhilMiller in #1998 (comment)
@JacobDomagala JacobDomagala self-assigned this Oct 25, 2022
JacobDomagala added a commit that referenced this issue Oct 28, 2022
@JacobDomagala
#2002: Runnable: Rename begin()/end() to start()/finish()
dbb22bd
@JacobDomagala JacobDomagala mentioned this issue Oct 28, 2022
Merged
JacobDomagala added a commit that referenced this issue Nov 3, 2022
@JacobDomagala
#2002: Context: Fix typo
ddb5cae
JacobDomagala added a commit that referenced this issue Nov 8, 2022
@JacobDomagala
#2002: Context: Fix typo
963f59b
JacobDomagala added a commit that referenced this issue Nov 9, 2022
@JacobDomagala
#2002: Runnable: Rename begin()/end() to start()/finish()
424a0ed
JacobDomagala added a commit that referenced this issue Nov 9, 2022
@JacobDomagala
#2002: Context: Fix typo
83cf57e
JacobDomagala added a commit that referenced this issue Nov 14, 2022
@JacobDomagala
#2002: Runnable: Rename begin()/end() to start()/finish()
5a16704
JacobDomagala added a commit that referenced this issue Nov 14, 2022
@JacobDomagala
#2002: Context: Fix typo
debc638
cz4rs pushed a commit that referenced this issue Dec 28, 2022
@JacobDomagala @cz4rs
#2002: Runnable: Rename begin()/end() to start()/finish()
54d0996
cz4rs pushed a commit that referenced this issue Dec 28, 2022
@JacobDomagala @cz4rs
#2002: Context: Fix typo
cc23d30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2002: Runnable: Rename begin()/end() to start()/finish() DARMA-tasking/vt
2 participants
@PhilMiller @JacobDomagala