Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1903: Add const to methods in LoadModel #1980

Merged
merged 1 commit into from
Sep 27, 2022
Merged

#1903: Add const to methods in LoadModel #1980

merged 1 commit into from
Sep 27, 2022

Conversation

thearusable
Copy link
Contributor

Closes #1903

@thearusable thearusable self-assigned this Sep 26, 2022
@github-actions
Copy link

github-actions bot commented Sep 26, 2022 •
edited
Loading

Pipelines results

PR tests (clang-3.9, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 8ddfd84

Compilation - successful

Testing - passed

Build log

cz4rs
cz4rs approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, gcc-7 failure seems unrelated.

@lifflander lifflander merged commit c69e439 into develop Sep 27, 2022
cz4rs pushed a commit that referenced this pull request Sep 28, 2022
@lifflander @cz4rs
Merge pull request #1980 from DARMA-tasking/1903-mark-methods-as-const
8883d4e 
#1903: Add const to methods in LoadModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobDomagala JacobDomagala JacobDomagala approved these changes

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

@nlslatt nlslatt Awaiting requested review from nlslatt

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make LoadModel::getModeled* methods const
4 participants
@thearusable @lifflander @cz4rs @JacobDomagala