Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make LoadModel::getModeled* methods const #1903

Closed
cz4rs opened this issue Aug 9, 2022 · 0 comments · Fixed by #1980
Closed

make LoadModel::getModeled* methods const #1903

cz4rs opened this issue Aug 9, 2022 · 0 comments · Fixed by #1980
Assignees
@thearusable
Labels
intro A potentially good introductory issue for a new developer to address pri: low type: task

Comments

@cz4rs
Copy link
Contributor

cz4rs commented Aug 9, 2022

What Needs to be Done?
Improve LoadModel interface by making LoadModel::getModeledLoad, LoadModel::getModeledComm, LoadModel::getModeledWork methods const.

Based on the discussion here: #1888 (comment).
@cz4rs cz4rs added type: task pri: low intro A potentially good introductory issue for a new developer to address labels Aug 9, 2022
@cz4rs cz4rs mentioned this issue Aug 9, 2022
Merged
@nmm0 nmm0 mentioned this issue Aug 9, 2022
Open
thearusable added a commit that referenced this issue Sep 26, 2022
@thearusable
#1903: Add const to methods in LoadModel
8ddfd84
@thearusable thearusable mentioned this issue Sep 26, 2022
Merged
lifflander added a commit that referenced this issue Sep 27, 2022
@lifflander
Merge pull request #1980 from DARMA-tasking/1903-mark-methods-as-const
c69e439 
#1903: Add const to methods in LoadModel
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@thearusable @cz4rs
#1903: Add const to methods in LoadModel
5d89db2
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
Merge pull request #1980 from DARMA-tasking/1903-mark-methods-as-const
8883d4e 
#1903: Add const to methods in LoadModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearusable thearusable

Labels
intro A potentially good introductory issue for a new developer to address pri: low type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1903: Add const to methods in LoadModel DARMA-tasking/vt
2 participants
@cz4rs @thearusable