Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1740: upgrade MPICH version #1741

Merged
merged 7 commits into from
Apr 26, 2022
Merged

1740: upgrade MPICH version #1741

merged 7 commits into from
Apr 26, 2022

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Apr 19, 2022

fixes #1740


After the changes ubuntu-18, nvidia and alpine builds are using older version of MPICH (3.3.2).

I have tried upgrading Alpine image as well, but it has been erroring out with undefined reference to pthread_yield'` (when building MPICH).

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (gcc-5, ubuntu, mpich)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (clang-3.9, ubuntu, mpich)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (clang-5.0, ubuntu, mpich)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (gcc-6, ubuntu, mpich)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (clang-10, ubuntu, mpich)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (clang-9, ubuntu, mpich)

Build for 4f42222

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (clang-10, alpine, mpich)

Build for 4f42222

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 19, 2022

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for d03eb53

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

Add python3 package to Docker images using MPICH 4.0.2.
@cz4rs cz4rs force-pushed the 1740-upgrade-mpich branch from 35f2915 to 06fe741 Compare April 20, 2022 14:38
Do not upgrade MPICH version in Alpine image to avoid `undefined reference
to `pthread_yield'` error (while building libfabric).
@cz4rs cz4rs marked this pull request as ready for review April 20, 2022 17:10
@jstrzebonski
Copy link
Contributor

About the errors, CMake produces some funny logs:

...
-- Found Git: /usr/bin/git (found version "2.17.1") 

fatal: unsafe repository ('/vt' is owned by someone else) 

To add an exception for this directory, call: 

 

	git config --global --add safe.directory /vt 

-- git invocation failed, git info cannot be obtained 
...

and later, when building:

...
[ninja][75/374] Generating vt/configs/generated/vt_git_revision.cc 

-- Reading head file 

-- Using git executable at "/usr/bin/git" 

-- GIT_REFSPEC: "" 

fatal: not a git repository (or any parent up to mount point /) 

Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). 

-- could not get the git sha1 

-- GIT_SHA1: "" 

fatal: not a git repository (or any parent up to mount point /) 

Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). 

-- could not get the exact git tag 

-- GIT_EXACT_TAG: "" 

fatal: not a git repository (or any parent up to mount point /) 

Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). 

-- could not get the description 

-- GIT_DESCRIPTION: "" 

fatal: not a git repository (or any parent up to mount point /) 

Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). 

-- Git Clean Status: "DIRTY" 

-- Configuring /vt/vt_git_revision.cc.in to generate /build/vt/src/vt/configs/generated/vt_git_revision.cc. 

[ninja][76/374] Linking C executable lib/brotli/brotli 
...

@nmm0

@cz4rs
Copy link
Contributor Author

cz4rs commented Apr 21, 2022

Yep, the git errors observed are not related to this PR. I have posted a separate issue (#1742).
This works just fine for me locally, so I expect some changes in Azure setup / default configuration.

Copy link
Contributor

@jstrzebonski jstrzebonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from strange errors, changes look good to me.

Copy link
Contributor

@JacobDomagala JacobDomagala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cz4rs cz4rs force-pushed the 1740-upgrade-mpich branch 3 times, most recently from 6c44954 to 4f42222 Compare April 25, 2022 12:33
@cz4rs cz4rs force-pushed the 1740-upgrade-mpich branch from 4f42222 to d03eb53 Compare April 25, 2022 13:56
output_name = ci/azure/azure-clang-9-ubuntu-mpich.yml
vt_build_shared_libs = 1
vt_inclusion = EXT_LIB
vt_werror = 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Werror flag has to be disabled because of newer glibc version - see #1513.

@github-actions
Copy link

PR tests (clang-11, ubuntu, mpich)

Build for d03eb53

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade MPICH version in Docker images
5 participants