1544: Implement default_map for indices with more than 3 dimensions #1730

JacobDomagala · 2022-04-05T13:45:29Z

github-actions · 2022-04-05T14:05:23Z

PR tests (gcc-5, ubuntu, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:06:36Z

PR tests (clang-5.0, ubuntu, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:07:19Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:07:37Z

PR tests (clang-3.9, ubuntu, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

codecov · 2022-04-05T14:09:50Z

Codecov Report

Merging #1730 (c2f3118) into develop (a9753fe) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1730      +/-   ##
===========================================
- Coverage    84.34%   84.31%   -0.03%     
===========================================
  Files          758      758              
  Lines        26708    26715       +7     
===========================================
- Hits         22526    22524       -2     
- Misses        4182     4191       +9

Impacted Files	Coverage Δ
src/vt/topos/index/dense/dense_array.h	`100.00% <ø> (ø)`
src/vt/topos/mapping/dense/dense.impl.h	`98.03% <100.00%> (+0.16%)`	⬆️
...unit/collection/test_collection_construct_common.h	`100.00% <100.00%> (ø)`
tests/unit/collection/test_construct.cc	`100.00% <100.00%> (ø)`
src/vt/phase/phase_manager.cc	`92.43% <0.00%> (-1.69%)`	⬇️
src/vt/vrt/collection/manager.impl.h	`95.44% <0.00%> (-1.00%)`	⬇️

github-actions · 2022-04-05T14:10:36Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:11:28Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:12:23Z

PR tests (gcc-6, ubuntu, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:21:54Z

PR tests (clang-9, ubuntu, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:24:57Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:25:27Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:32:46Z

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T14:34:45Z

PR tests (clang-10, alpine, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

github-actions · 2022-04-05T15:00:16Z

PR tests (clang-10, ubuntu, mpich)

Build for c5bc220

Compilation - successful

Testing - passed

Build log

JacobDomagala · 2022-04-12T16:41:08Z

Codecov issue should be resolved after #1736 is fixed.

github-actions · 2022-06-06T14:50:19Z

Pipelines results

PR tests (clang-3.9, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for c2f3118

Compilation - successful

Testing - passed

Build log

src/vt/topos/mapping/dense/dense.h

lifflander

Looks good to me!

… dimensions

…construct

jstrzebonski

Looks good.

JacobDomagala self-assigned this Apr 5, 2022

nlslatt mentioned this pull request Apr 5, 2022

Meeting Agenda [do not close] #925

Open

JacobDomagala force-pushed the 1544-add-backup-option-for-default-map branch 2 times, most recently from 54c5110 to c5bc220 Compare April 20, 2022 12:08

JacobDomagala force-pushed the 1544-add-backup-option-for-default-map branch from c5bc220 to 33f9b6b Compare June 6, 2022 14:34

JacobDomagala force-pushed the 1544-add-backup-option-for-default-map branch 3 times, most recently from a740792 to ddbe5bf Compare June 7, 2022 15:31

JacobDomagala marked this pull request as ready for review June 7, 2022 16:41

JacobDomagala requested review from jstrzebonski, lifflander, cz4rs and PhilMiller June 7, 2022 16:41

cz4rs reviewed Jun 7, 2022

View reviewed changes

src/vt/topos/mapping/dense/dense.h Outdated Show resolved Hide resolved

lifflander approved these changes Jun 7, 2022

View reviewed changes

JacobDomagala force-pushed the 1544-add-backup-option-for-default-map branch from 3b58445 to d7bb3a5 Compare June 8, 2022 17:15

cz4rs approved these changes Jun 9, 2022

View reviewed changes

JacobDomagala added 4 commits June 9, 2022 22:51

#1544: Add unit test for Collection with indicies over 3 dimensions

78708f2

#1544: collection: Implement default_map for indices with more than 3…

a4832ac

… dimensions

#1544: Tests: Reduce number of elements for 4 dim Collection in test_…

25e57df

…construct

#1544: Mapping: Remove redundant type aliases for N-dim indices

c2f3118

JacobDomagala force-pushed the 1544-add-backup-option-for-default-map branch from d7bb3a5 to c2f3118 Compare June 9, 2022 20:51

jstrzebonski approved these changes Jun 10, 2022

View reviewed changes

lifflander merged commit 39230e6 into develop Jun 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1544: Implement default_map for indices with more than 3 dimensions #1730

1544: Implement default_map for indices with more than 3 dimensions #1730

JacobDomagala commented Apr 5, 2022

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

codecov bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

JacobDomagala commented Apr 12, 2022

github-actions bot commented Jun 6, 2022 •

edited

Loading

lifflander left a comment

jstrzebonski left a comment

1544: Implement default_map for indices with more than 3 dimensions #1730

1544: Implement default_map for indices with more than 3 dimensions #1730

Conversation

JacobDomagala commented Apr 5, 2022

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

codecov bot commented Apr 5, 2022 • edited Loading

Codecov Report

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

github-actions bot commented Apr 5, 2022 • edited Loading

JacobDomagala commented Apr 12, 2022

github-actions bot commented Jun 6, 2022 • edited Loading

Pipelines results

lifflander left a comment

Choose a reason for hiding this comment

jstrzebonski left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

codecov bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

github-actions bot commented Jun 6, 2022 •

edited

Loading