Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indices over 3-dimensions fail to compile because DefaultMap does not have a backup option #1544

Closed
lifflander opened this issue Aug 26, 2021 · 1 comment · Fixed by #1730
Closed

Indices over 3-dimensions fail to compile because DefaultMap does not have a backup option #1544

lifflander opened this issue Aug 26, 2021 · 1 comment · Fixed by #1730
Assignees
@JacobDomagala
Labels
type: bug

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

Right now, the SFINAE in vt::vrt::collection::DefaultMap fails unless the index is 1-d, 2-d, or 3-d. It should have a backup option.
@lifflander
Copy link
Collaborator Author

Write tests to cover higher dimensions that reveal this problem.

@lifflander lifflander mentioned this issue Feb 1, 2022
Open
JacobDomagala added a commit that referenced this issue Mar 14, 2022
@JacobDomagala
#1544: Add unit test for Collection with indicies over 3 dimensions
97e1015
JacobDomagala added a commit that referenced this issue Apr 5, 2022
@JacobDomagala
#1544: Add unit test for Collection with indicies over 3 dimensions
bdfbee4
JacobDomagala added a commit that referenced this issue Apr 5, 2022
@JacobDomagala
#1544: collection: Implement default_map for indices with more than 3…
68b4fbe 
… dimensions
@JacobDomagala JacobDomagala mentioned this issue Apr 5, 2022
Merged
JacobDomagala added a commit that referenced this issue Apr 18, 2022
@JacobDomagala
#1544: Add unit test for Collection with indicies over 3 dimensions
ed096e3
JacobDomagala added a commit that referenced this issue Apr 18, 2022
@JacobDomagala
#1544: collection: Implement default_map for indices with more than 3…
c029f5f 
… dimensions
JacobDomagala added a commit that referenced this issue Apr 18, 2022
@JacobDomagala
#1544: Tests: Reduce number of elements for 4 dim Collection in test_…
54c5110 
…construct
JacobDomagala added a commit that referenced this issue Apr 20, 2022
@JacobDomagala
#1544: Add unit test for Collection with indicies over 3 dimensions
7a5bbfb
JacobDomagala added a commit that referenced this issue Apr 20, 2022
@JacobDomagala
#1544: collection: Implement default_map for indices with more than 3…
bde766a 
… dimensions
JacobDomagala added a commit that referenced this issue Apr 20, 2022
@JacobDomagala
#1544: Tests: Reduce number of elements for 4 dim Collection in test_…
c5bc220 
…construct
JacobDomagala added a commit that referenced this issue Jun 6, 2022
@JacobDomagala
#1544: Add unit test for Collection with indicies over 3 dimensions
aa0fd91
JacobDomagala added a commit that referenced this issue Jun 6, 2022
@JacobDomagala
#1544: collection: Implement default_map for indices with more than 3…
302e2e1 
… dimensions
JacobDomagala added a commit that referenced this issue Jun 6, 2022
@JacobDomagala
#1544: Tests: Reduce number of elements for 4 dim Collection in test_…
33f9b6b 
…construct
JacobDomagala added a commit that referenced this issue Jun 6, 2022
@JacobDomagala
#1544: Tests: Reduce number of elements for 4 dim Collection in test_…
210b7df 
…construct
JacobDomagala added a commit that referenced this issue Jun 6, 2022
@JacobDomagala
#1544: Add unit test for Collection with indicies over 3 dimensions
fe708cb
JacobDomagala added a commit that referenced this issue Jun 6, 2022
@JacobDomagala
#1544: collection: Implement default_map for indices with more than 3…
737ae79 
… dimensions
JacobDomagala added a commit that referenced this issue Jun 6, 2022
@JacobDomagala
#1544: Tests: Reduce number of elements for 4 dim Collection in test_…
a740792 
…construct
JacobDomagala added a commit that referenced this issue Jun 7, 2022
@JacobDomagala
#1544: Tests: Reduce number of elements for 4 dim Collection in test_…
ddbe5bf 
…construct
JacobDomagala added a commit that referenced this issue Jun 7, 2022
@JacobDomagala
#1544: Mapping: Remove redundant type aliases for N-dim indices
3b58445
JacobDomagala added a commit that referenced this issue Jun 8, 2022
@JacobDomagala
#1544: Add unit test for Collection with indicies over 3 dimensions
bc51c3c
JacobDomagala added a commit that referenced this issue Jun 8, 2022
@JacobDomagala
#1544: collection: Implement default_map for indices with more than 3…
c5c8f5a 
… dimensions
JacobDomagala added a commit that referenced this issue Jun 8, 2022
@JacobDomagala
#1544: Tests: Reduce number of elements for 4 dim Collection in test_…
bec315d 
…construct
JacobDomagala added a commit that referenced this issue Jun 8, 2022
@JacobDomagala
#1544: Mapping: Remove redundant type aliases for N-dim indices
d7bb3a5
JacobDomagala added a commit that referenced this issue Jun 9, 2022
@JacobDomagala
#1544: Add unit test for Collection with indicies over 3 dimensions
78708f2
JacobDomagala added a commit that referenced this issue Jun 9, 2022
@JacobDomagala
#1544: collection: Implement default_map for indices with more than 3…
a4832ac 
… dimensions
JacobDomagala added a commit that referenced this issue Jun 9, 2022
@JacobDomagala
#1544: Tests: Reduce number of elements for 4 dim Collection in test_…
25e57df 
…construct
JacobDomagala added a commit that referenced this issue Jun 9, 2022
@JacobDomagala
#1544: Mapping: Remove redundant type aliases for N-dim indices
c2f3118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1544: Implement default_map for indices with more than 3 dimensions DARMA-tasking/vt
2 participants
@lifflander @JacobDomagala