Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1125 scheduler: template runInEpoch* functions #1133

Merged
merged 3 commits into from
Nov 4, 2020
Merged

1125 scheduler: template runInEpoch* functions #1133

merged 3 commits into from
Nov 4, 2020

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Oct 29, 2020 •
edited
Loading

Fixes #1125

  • implementation
  • unit tests

@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #1133 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1133      +/-   ##
===========================================
+ Coverage    79.18%   79.19%   +0.01%     
===========================================
  Files          713      714       +1     
  Lines        26917    26939      +22     
===========================================
+ Hits         21313    21335      +22     
  Misses        5604     5604
Impacted Files Coverage Δ
src/vt/scheduler/scheduler.cc 81.13% <ø> (-1.92%) ⬇️
src/vt/scheduler/scheduler.h 100.00% <ø> (ø)
src/vt/scheduler/scheduler.impl.h 100.00% <100.00%> (ø)
tests/unit/scheduler/test_high_level_calls.cc 100.00% <100.00%> (ø)

@cz4rs cz4rs force-pushed the 1125-templated-run-in-epoch branch from 140caa4 to 3f90d0b Compare October 30, 2020 23:10
@cz4rs cz4rs marked this pull request as ready for review October 30, 2020 23:11
@cz4rs cz4rs force-pushed the 1125-templated-run-in-epoch branch from 3f90d0b to a124269 Compare October 30, 2020 23:11
lifflander
lifflander approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me

@cz4rs cz4rs force-pushed the 1125-templated-run-in-epoch branch from fec7a83 to 4531cf0 Compare November 2, 2020 21:17
jstrzebonski
jstrzebonski approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@jstrzebonski jstrzebonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK.

@cz4rs cz4rs force-pushed the 1125-templated-run-in-epoch branch from 4531cf0 to 04e0a8d Compare November 3, 2020 13:05
@cz4rs
Copy link
Contributor Author

cz4rs commented Nov 3, 2020

(re-running to get Codacy/PR Quality Review to pass)

@cz4rs cz4rs force-pushed the 1125-templated-run-in-epoch branch from 04e0a8d to c95db71 Compare November 3, 2020 20:02
@lifflander lifflander merged commit 9119934 into develop Nov 4, 2020
@cz4rs cz4rs mentioned this pull request Jun 15, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller left review comments

@jstrzebonski jstrzebonski jstrzebonski approved these changes

@JacobDomagala JacobDomagala JacobDomagala approved these changes

@lifflander lifflander lifflander approved these changes

@bradybray bradybray Awaiting requested review from bradybray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runInEpoch* do not take a universal reference (they take a r-val ref)
5 participants
@cz4rs @PhilMiller @lifflander @JacobDomagala @jstrzebonski