-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runInEpoch* do not take a universal reference (they take a r-val ref) #1125
Labels
Comments
Also, write tests for these to avoid problems like this coming up |
cz4rs
added a commit
that referenced
this issue
Oct 29, 2020
2 tasks
cz4rs
added a commit
that referenced
this issue
Oct 29, 2020
cz4rs
added a commit
that referenced
this issue
Oct 30, 2020
cz4rs
added a commit
that referenced
this issue
Oct 30, 2020
Make sure that vt::runInEpoch* accepts std::function as an argument.
cz4rs
added a commit
that referenced
this issue
Oct 30, 2020
cz4rs
added a commit
that referenced
this issue
Oct 30, 2020
Make sure that vt::runInEpoch* accepts std::function as an argument.
Changes implemented, typo in the description? (it was not possible to pass std::function before and it is possible now, after templating the functions) |
cz4rs
added a commit
that referenced
this issue
Nov 2, 2020
cz4rs
added a commit
that referenced
this issue
Nov 2, 2020
cz4rs
added a commit
that referenced
this issue
Nov 3, 2020
cz4rs
added a commit
that referenced
this issue
Nov 3, 2020
cz4rs
added a commit
that referenced
this issue
Nov 3, 2020
Make sure that vt::runInEpoch* accepts std::function as an argument.
cz4rs
added a commit
that referenced
this issue
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What Needs to be Done?
Due to this, you can pass an existing std::function to them. Template them and move to the header file. Something like this would work:
The text was updated successfully, but these errors were encountered: