Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode member collection handler types in the bit pattern for the handler #872

Closed
lifflander opened this issue Jun 21, 2020 · 1 comment · Fixed by #1118
Closed

Encode member collection handler types in the bit pattern for the handler #872

lifflander opened this issue Jun 21, 2020 · 1 comment · Fixed by #1118
Assignees

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

Right now, in {send,broadcast}UntypedHandler we pass around a boolean member to distinguish the handler type (member vs. function) on the send and receive side after the handler is registered. That bit can easily fit in the 64-bits for HandlerType. Encode it, remove it from messages, and from the interface.

@lifflander
Copy link
Collaborator Author

@jstrzebonski Can you work on this next? Right now in theCollection API, we have a boolean that gets passed around a lot the encodes whether the handers is on a member or function. I would like to include this in the handler bit pattern somehow, so we don't have to explicitly store this state everywhere.

jstrzebonski pushed a commit that referenced this issue Oct 27, 2020
jstrzebonski pushed a commit that referenced this issue Oct 27, 2020
jstrzebonski pushed a commit that referenced this issue Oct 29, 2020
jstrzebonski pushed a commit that referenced this issue Oct 29, 2020
jstrzebonski pushed a commit that referenced this issue Oct 30, 2020
jstrzebonski pushed a commit that referenced this issue Oct 30, 2020
jstrzebonski pushed a commit that referenced this issue Oct 30, 2020
jstrzebonski pushed a commit that referenced this issue Oct 30, 2020
jstrzebonski pushed a commit that referenced this issue Nov 3, 2020
jstrzebonski pushed a commit that referenced this issue Nov 3, 2020
jstrzebonski pushed a commit that referenced this issue Nov 3, 2020
jstrzebonski pushed a commit that referenced this issue Nov 3, 2020
jstrzebonski pushed a commit that referenced this issue Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants