#872: remove redundant references

DARMA-tasking · Nov 4, 2020 · 5e00be2 · 5e00be2
1 parent 9a3dfd6
commit 5e00be2
Show file tree

Hide file tree

Showing 61 changed files with 148 additions and 146 deletions.
diff --git a/src/vt/messaging/active.cc b/src/vt/messaging/active.cc
@@ -1073,7 +1073,7 @@ HandlerType ActiveMessenger::collectiveRegisterHandler(
 }
 
 void ActiveMessenger::swapHandlerFn(
-  HandlerType const& han, ActiveClosureFnType fn, TagType const& tag
+  HandlerType const han, ActiveClosureFnType fn, TagType const& tag
 ) {
   vt_debug_print(
     active, node,
@@ -1088,7 +1088,7 @@ void ActiveMessenger::swapHandlerFn(
 }
 
 void ActiveMessenger::deliverPendingMsgsHandler(
-  HandlerType const& han, TagType const& tag
+  HandlerType const han, TagType const& tag
 ) {
   vt_debug_print(
     active, node,
@@ -1118,7 +1118,7 @@ void ActiveMessenger::deliverPendingMsgsHandler(
 }
 
 void ActiveMessenger::registerHandlerFn(
-  HandlerType const& han, ActiveClosureFnType fn, TagType const& tag
+  HandlerType const han, ActiveClosureFnType fn, TagType const& tag
 ) {
   vt_debug_print(
     active, node,
@@ -1133,7 +1133,7 @@ void ActiveMessenger::registerHandlerFn(
 }
 
 void ActiveMessenger::unregisterHandlerFn(
-  HandlerType const& han, TagType const& tag
+  HandlerType const han, TagType const& tag
 ) {
   vt_debug_print(
     active, node,

diff --git a/src/vt/messaging/active.h b/src/vt/messaging/active.h
@@ -1185,7 +1185,7 @@ struct ActiveMessenger : runtime::component::PollableComponent<ActiveMessenger>
    * \param[in] tag the tag this handler will accept (\c vt::no_tag means any)
    */
   void swapHandlerFn(
-    HandlerType const& han, ActiveClosureFnType fn, TagType const& tag = no_tag
+    HandlerType const han, ActiveClosureFnType fn, TagType const& tag = no_tag
   );
 
   /**
@@ -1195,7 +1195,7 @@ struct ActiveMessenger : runtime::component::PollableComponent<ActiveMessenger>
    * \param[in] han the handler to de-register
    * \param[in] tag the tag this handler will accept (\c vt::no_tag means any)
    */
-  void unregisterHandlerFn(HandlerType const& han, TagType const& tag = no_tag);
+  void unregisterHandlerFn(HandlerType const han, TagType const& tag = no_tag);
 
   /**
    * \internal
@@ -1206,7 +1206,7 @@ struct ActiveMessenger : runtime::component::PollableComponent<ActiveMessenger>
    * \param[in] tag the tag this handler will accept (\c vt::no_tag means any)
    */
   void registerHandlerFn(
-    HandlerType const& han, ActiveClosureFnType fn, TagType const& tag = no_tag
+    HandlerType const han, ActiveClosureFnType fn, TagType const& tag = no_tag
   );
 
   /**
@@ -1338,7 +1338,7 @@ struct ActiveMessenger : runtime::component::PollableComponent<ActiveMessenger>
    * \param[in] tag the tag for that handler
    */
   void deliverPendingMsgsHandler(
-    HandlerType const& han, TagType const& tag = no_tag
+    HandlerType const han, TagType const& tag = no_tag
   );
 
   /**

diff --git a/src/vt/messaging/envelope/envelope_set.h b/src/vt/messaging/envelope/envelope_set.h
@@ -124,7 +124,7 @@ inline void setTagType(Env& env);
  * \param[in] handler the handler
  */
 template <typename Env>
-inline void envelopeSetHandler(Env& env, HandlerType const& handler);
+inline void envelopeSetHandler(Env& env, HandlerType const handler);
 
 /**
  * \brief Set destination \c dest field in envelope

diff --git a/src/vt/messaging/envelope/envelope_set.impl.h b/src/vt/messaging/envelope/envelope_set.impl.h
@@ -94,7 +94,7 @@ inline void setTagType(Env& env) {
 }
 
 template <typename Env>
-inline void envelopeSetHandler(Env& env, HandlerType const& handler) {
+inline void envelopeSetHandler(Env& env, HandlerType const handler) {
   vtAssert(not envelopeIsLocked(env), "Envelope locked.");
   reinterpret_cast<Envelope*>(&env)->han = handler;
 }

diff --git a/src/vt/messaging/envelope/envelope_setup.h b/src/vt/messaging/envelope/envelope_setup.h
@@ -62,7 +62,7 @@ namespace vt {
  */
 template <typename Env>
 inline void envelopeSetup(
-  Env& env, NodeType const& dest, HandlerType const& handler
+  Env& env, NodeType const& dest, HandlerType const handler
 );
 
 /**

diff --git a/src/vt/messaging/envelope/envelope_setup.impl.h b/src/vt/messaging/envelope/envelope_setup.impl.h
@@ -53,7 +53,7 @@ namespace vt {
 
 template <typename Env>
 inline void envelopeSetup(
-  Env& env, NodeType const& dest, HandlerType const& handler
+  Env& env, NodeType const& dest, HandlerType const handler
 ) {
   envelopeSetDest(env, dest);
   envelopeSetHandler(env, handler);

diff --git a/src/vt/parameterization/parameterization.h b/src/vt/parameterization/parameterization.h
@@ -73,12 +73,12 @@ struct DataMsg : vt::Message {
   HandlerType sub_han = uninitialized_handler;
 
   DataMsg() = default;
-  DataMsg(HandlerType const& in_sub_han, Tuple&& a)
+  DataMsg(HandlerType const in_sub_han, Tuple&& a)
     : Message(), tup(std::forward<Tuple>(a)), sub_han(in_sub_han)
   { }
 
   template <typename... Args>
-  DataMsg(HandlerType const& in_sub_han, Args&&... a)
+  DataMsg(HandlerType const in_sub_han, Args&&... a)
     : Message(), tup(std::forward<Args>(a)...), sub_han(in_sub_han)
   { }
 
@@ -144,7 +144,7 @@ struct Param : runtime::component::Component<Param> {
 
   template <typename... Args>
   void sendDataTuple(
-    NodeType const& dest, HandlerType const& han, std::tuple<Args...>&& tup
+    NodeType const& dest, HandlerType const han, std::tuple<Args...>&& tup
   ) {
     staticCheckCopyable<Args...>();
 
@@ -168,7 +168,7 @@ struct Param : runtime::component::Component<Param> {
 
   template <typename DataMsg>
   void sendDataMsg(
-    NodeType const& dest, HandlerType const& __attribute__((unused)) han,
+    NodeType const& dest, HandlerType const __attribute__((unused)) han,
     MsgSharedPtr<DataMsg> m
   ) {
     auto pmsg = promoteMsg(m.get());

diff --git a/src/vt/pipe/callback/cb_union/cb_raw.h b/src/vt/pipe/callback/cb_union/cb_raw.h
@@ -65,15 +65,15 @@ struct AnonCB : CallbackAnonTypeless { };
 struct SendMsgCB : CallbackSendTypeless {
   SendMsgCB() = default;
   SendMsgCB(
-    HandlerType const& in_handler, NodeType const& in_send_node
+    HandlerType const in_handler, NodeType const& in_send_node
   ) : CallbackSendTypeless(in_handler, in_send_node)
   { }
 };
 
 struct BcastMsgCB : CallbackBcastTypeless {
   BcastMsgCB() = default;
   BcastMsgCB(
-    HandlerType const& in_handler, bool const& in_include
+    HandlerType const in_handler, bool const& in_include
   ) : CallbackBcastTypeless(in_handler, in_include)
   { }
 };
@@ -89,8 +89,8 @@ struct BcastColMsgCB : CallbackProxyBcastTypeless {
 struct BcastColDirCB : CallbackProxyBcastDirect {
   BcastColDirCB() = default;
   BcastColDirCB(
-    HandlerType const& in_handler,
-    CallbackProxyBcastDirect::AutoHandlerType const& in_vrt_handler,
+    HandlerType const in_handler,
+    CallbackProxyBcastDirect::AutoHandlerType const in_vrt_handler,
     VirtualProxyType const& in_proxy
   ) : CallbackProxyBcastDirect(in_handler, in_vrt_handler, in_proxy)
   { }

diff --git a/src/vt/pipe/callback/cb_union/cb_raw_base.cc b/src/vt/pipe/callback/cb_union/cb_raw_base.cc
@@ -49,13 +49,13 @@
 namespace vt { namespace pipe { namespace callback { namespace cbunion {
 
 CallbackRawBaseSingle::CallbackRawBaseSingle(
-  RawSendMsgTagType, PipeType const& in_pipe, HandlerType const& in_handler,
+  RawSendMsgTagType, PipeType const& in_pipe, HandlerType const in_handler,
   NodeType const& in_node
 ) : pipe_(in_pipe), cb_(SendMsgCB{in_handler,in_node})
 { }
 
 CallbackRawBaseSingle::CallbackRawBaseSingle(
-  RawBcastMsgTagType, PipeType const& in_pipe, HandlerType const& in_handler,
+  RawBcastMsgTagType, PipeType const& in_pipe, HandlerType const in_handler,
   bool const& in_inc
 ) : pipe_(in_pipe), cb_(BcastMsgCB{in_handler,in_inc})
 { }
@@ -76,8 +76,8 @@ CallbackRawBaseSingle::CallbackRawBaseSingle(
 { }
 
 CallbackRawBaseSingle::CallbackRawBaseSingle(
-  RawBcastColDirTagType, PipeType const& in_pipe, HandlerType const& in_handler,
-  AutoHandlerType const& in_vrt, VirtualProxyType const& in_proxy
+  RawBcastColDirTagType, PipeType const& in_pipe, HandlerType const in_handler,
+  AutoHandlerType const in_vrt, VirtualProxyType const& in_proxy
 ) : pipe_(in_pipe), cb_(BcastColDirCB{in_handler, in_vrt, in_proxy})
 { }
 

diff --git a/src/vt/pipe/callback/cb_union/cb_raw_base.h b/src/vt/pipe/callback/cb_union/cb_raw_base.h
@@ -85,24 +85,24 @@ struct CallbackRawBaseSingle {
 
   // Constructors for different types of callbacks
   CallbackRawBaseSingle(
-    RawSendMsgTagType, PipeType const& in_pipe, HandlerType const& in_handler,
+    RawSendMsgTagType, PipeType const& in_pipe, HandlerType const in_handler,
     NodeType const& in_node
   );
   CallbackRawBaseSingle(
-    RawBcastMsgTagType, PipeType const& in_pipe, HandlerType const& in_handler,
+    RawBcastMsgTagType, PipeType const& in_pipe, HandlerType const in_handler,
     bool const& in_inc
   );
   CallbackRawBaseSingle(RawAnonTagType, PipeType const& in_pipe);
   CallbackRawBaseSingle(RawSendColMsgTagType, PipeType const& in_pipe);
   CallbackRawBaseSingle(RawBcastColMsgTagType, PipeType const& in_pipe);
   CallbackRawBaseSingle(
     RawBcastColDirTagType, PipeType const& in_pipe,
-    HandlerType const& in_handler, AutoHandlerType const& in_vrt,
+    HandlerType const in_handler, AutoHandlerType const in_vrt,
     VirtualProxyType const& in_proxy
   );
   CallbackRawBaseSingle(
     RawSendColDirTagType, PipeType const& in_pipe,
-    HandlerType const& in_handler, AutoHandlerType const& in_vrt_handler,
+    HandlerType const in_handler, AutoHandlerType const in_vrt_handler,
     void* index_bits
   );
   CallbackRawBaseSingle(
@@ -167,12 +167,12 @@ struct CallbackTyped : CallbackRawBaseSingle {
 
   // Forwarding constructors for different types of callbacks
   CallbackTyped(
-    RawSendMsgTagType, PipeType const& in_pipe, HandlerType const& in_handler,
+    RawSendMsgTagType, PipeType const& in_pipe, HandlerType const in_handler,
     NodeType const& in_node
   ) : CallbackRawBaseSingle(RawSendMsgTag,in_pipe,in_handler,in_node)
   { }
   CallbackTyped(
-    RawBcastMsgTagType, PipeType const& in_pipe, HandlerType const& in_handler,
+    RawBcastMsgTagType, PipeType const& in_pipe, HandlerType const in_handler,
     bool const& in_inc
   )  : CallbackRawBaseSingle(RawBcastMsgTag,in_pipe,in_handler,in_inc)
   { }
@@ -187,15 +187,15 @@ struct CallbackTyped : CallbackRawBaseSingle {
   { }
   CallbackTyped(
     RawBcastColDirTagType, PipeType const& in_pipe,
-    HandlerType const& in_handler, AutoHandlerType const& in_vrt,
+    HandlerType const in_handler, AutoHandlerType const in_vrt,
     VirtualProxyType const& in_proxy
   ) : CallbackRawBaseSingle(
         RawBcastColDirTag, in_pipe, in_handler, in_vrt, in_proxy
       )
   { }
   CallbackTyped(
     RawSendColDirTagType, PipeType const& in_pipe,
-    HandlerType const& in_handler, AutoHandlerType const& in_vrt_handler,
+    HandlerType const in_handler, AutoHandlerType const in_vrt_handler,
     void* index_bits
   ) : CallbackRawBaseSingle(
         RawSendColDirTag,in_pipe,in_handler,in_vrt_handler,index_bits

diff --git a/src/vt/pipe/callback/handler_bcast/callback_bcast.h b/src/vt/pipe/callback/handler_bcast/callback_bcast.h
@@ -74,7 +74,7 @@ struct CallbackBcast : CallbackBase<signal::Signal<MsgT>> {
   CallbackBcast(CallbackBcast&&) = default;
 
   CallbackBcast(
-    HandlerType const& in_handler, bool const& in_include
+    HandlerType const in_handler, bool const& in_include
   );
 
   HandlerType getHandler() const { return handler_; }

diff --git a/src/vt/pipe/callback/handler_bcast/callback_bcast.impl.h b/src/vt/pipe/callback/handler_bcast/callback_bcast.impl.h
@@ -59,7 +59,7 @@ namespace vt { namespace pipe { namespace callback {
 
 template <typename MsgT>
 CallbackBcast<MsgT>::CallbackBcast(
-  HandlerType const& in_handler, bool const& in_include
+  HandlerType const in_handler, bool const& in_include
 ) : handler_(in_handler), include_sender_(in_include)
 { }
 

diff --git a/src/vt/pipe/callback/handler_bcast/callback_bcast_tl.cc b/src/vt/pipe/callback/handler_bcast/callback_bcast_tl.cc
@@ -55,7 +55,7 @@
 namespace vt { namespace pipe { namespace callback {
 
 CallbackBcastTypeless::CallbackBcastTypeless(
-  HandlerType const& in_handler, bool const& in_include
+  HandlerType const in_handler, bool const& in_include
 ) : handler_(in_handler), include_sender_(in_include)
 { }
 

diff --git a/src/vt/pipe/callback/handler_bcast/callback_bcast_tl.h b/src/vt/pipe/callback/handler_bcast/callback_bcast_tl.h
@@ -60,7 +60,7 @@ struct CallbackBcastTypeless : CallbackBaseTL<CallbackBcastTypeless> {
   CallbackBcastTypeless& operator=(CallbackBcastTypeless const&) = default;
 
   CallbackBcastTypeless(
-    HandlerType const& in_handler, bool const& in_include
+    HandlerType const in_handler, bool const& in_include
   );
 
   HandlerType getHandler() const { return handler_; }

diff --git a/src/vt/pipe/callback/handler_send/callback_send.h b/src/vt/pipe/callback/handler_send/callback_send.h
@@ -76,7 +76,7 @@ struct CallbackSend : CallbackBase<signal::Signal<MsgT>> {
   CallbackSend(CallbackSend&&) = default;
 
   CallbackSend(
-    HandlerType const& in_handler, NodeType const& in_send_node
+    HandlerType const in_handler, NodeType const& in_send_node
   );
 
   HandlerType getHandler() const { return handler_; }

diff --git a/src/vt/pipe/callback/handler_send/callback_send.impl.h b/src/vt/pipe/callback/handler_send/callback_send.impl.h
@@ -56,7 +56,7 @@ namespace vt { namespace pipe { namespace callback {
 
 template <typename MsgT>
 CallbackSend<MsgT>::CallbackSend(
-  HandlerType const& in_handler, NodeType const& in_send_node
+  HandlerType const in_handler, NodeType const& in_send_node
 ) : send_node_(in_send_node), handler_(in_handler)
 { }
 

diff --git a/src/vt/pipe/callback/handler_send/callback_send_tl.cc b/src/vt/pipe/callback/handler_send/callback_send_tl.cc
@@ -54,7 +54,7 @@
 namespace vt { namespace pipe { namespace callback {
 
 CallbackSendTypeless::CallbackSendTypeless(
-  HandlerType const& in_handler, NodeType const& in_send_node
+  HandlerType const in_handler, NodeType const& in_send_node
 ) : send_node_(in_send_node), handler_(in_handler)
 { }
 

diff --git a/src/vt/pipe/callback/handler_send/callback_send_tl.h b/src/vt/pipe/callback/handler_send/callback_send_tl.h
@@ -59,7 +59,7 @@ struct CallbackSendTypeless : CallbackBaseTL<CallbackSendTypeless> {
   CallbackSendTypeless& operator=(CallbackSendTypeless const&) = default;
 
   CallbackSendTypeless(
-    HandlerType const& in_handler, NodeType const& in_send_node
+    HandlerType const in_handler, NodeType const& in_send_node
   );
 
   template <typename SerializerT>

diff --git a/src/vt/pipe/callback/objgroup_bcast/callback_objgroup_bcast.h b/src/vt/pipe/callback/objgroup_bcast/callback_objgroup_bcast.h
@@ -55,7 +55,7 @@ namespace vt { namespace pipe { namespace callback {
 struct CallbackObjGroupBcast : CallbackBaseTL<CallbackObjGroupBcast> {
   CallbackObjGroupBcast() = default;
   CallbackObjGroupBcast(
-    HandlerType const& in_han, ObjGroupProxyType const& in_objgroup
+    HandlerType const in_han, ObjGroupProxyType const& in_objgroup
   ) : handler_(in_han), objgroup_(in_objgroup)
   { }
 

diff --git a/src/vt/pipe/callback/proxy_bcast/callback_proxy_bcast.h b/src/vt/pipe/callback/proxy_bcast/callback_proxy_bcast.h
@@ -68,7 +68,7 @@ struct CallbackProxyBcast : CallbackBase<signal::Signal<MsgT>> {
   CallbackProxyBcast(CallbackProxyBcast const&) = default;
   CallbackProxyBcast(CallbackProxyBcast&&) = default;
 
-  CallbackProxyBcast(HandlerType const& in_handler, ProxyType const& in_proxy)
+  CallbackProxyBcast(HandlerType const in_handler, ProxyType const& in_proxy)
     : proxy_(in_proxy), handler_(in_handler)
   { }
 

diff --git a/src/vt/pipe/callback/proxy_bcast/callback_proxy_bcast_tl.h b/src/vt/pipe/callback/proxy_bcast/callback_proxy_bcast_tl.h
@@ -76,7 +76,7 @@ struct CallbackProxyBcastDirect : CallbackBaseTL<CallbackProxyBcastDirect> {
 
   CallbackProxyBcastDirect() = default;
   CallbackProxyBcastDirect(
-    HandlerType const& in_han, AutoHandlerType const& in_vrt,
+    HandlerType const in_han, AutoHandlerType const in_vrt,
     VirtualProxyType const& in_proxy
   ) : vrt_dispatch_han_(in_vrt), handler_(in_han), proxy_(in_proxy)
   { }

diff --git a/src/vt/pipe/callback/proxy_send/callback_proxy_send.h b/src/vt/pipe/callback/proxy_send/callback_proxy_send.h
@@ -68,13 +68,13 @@ struct CallbackProxySend : CallbackBase<signal::Signal<MsgT>> {
   using MessageType      = MsgT;
 
   CallbackProxySend(
-    HandlerType const& in_handler, IndexedProxyType const& in_proxy
+    HandlerType const in_handler, IndexedProxyType const& in_proxy
   ) : proxy_(in_proxy.getCollectionProxy()),
       idx_(in_proxy.getElementProxy().getIndex()), handler_(in_handler)
   { }
 
   CallbackProxySend(
-    HandlerType const& in_handler, ProxyType const& in_proxy,
+    HandlerType const in_handler, ProxyType const& in_proxy,
     IndexType const& in_idx
   ) : proxy_(in_proxy), idx_(in_idx), handler_(in_handler)
   { }

diff --git a/src/vt/pipe/callback/proxy_send/callback_proxy_send_tl.h b/src/vt/pipe/callback/proxy_send/callback_proxy_send_tl.h
@@ -75,7 +75,7 @@ struct CallbackProxySendDirect : CallbackBaseTL<CallbackProxySendDirect> {
   using AutoHandlerType = auto_registry::AutoHandlerType;
 
   CallbackProxySendDirect() = default;
-  CallbackProxySendDirect(HandlerType const& in_han, AutoHandlerType in_vrt)
+  CallbackProxySendDirect(HandlerType const in_han, AutoHandlerType in_vrt)
     : vrt_dispatch_han_(in_vrt), handler_(in_han)
   { }
 

diff --git a/src/vt/registry/auto/auto_registry.h b/src/vt/registry/auto/auto_registry.h
@@ -62,7 +62,7 @@
 
 namespace vt { namespace auto_registry {
 
-AutoActiveType getAutoHandler(HandlerType const& handler);
+AutoActiveType getAutoHandler(HandlerType const handler);
 
 AutoActiveObjGroupType getAutoHandlerObjGroup(HandlerType han);
 AutoHandlerType getAutoHandlerObjTypeIdx(HandlerType han);