Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested trace user events output in wrong order #2187

Closed
lifflander opened this issue Sep 5, 2023 · 0 comments · Fixed by #2188
Closed

Nested trace user events output in wrong order #2187

lifflander opened this issue Sep 5, 2023 · 0 comments · Fixed by #2188
Assignees
@lifflander @thearusable
Labels
type: bug

Comments

@lifflander
Copy link
Collaborator

Describe the bug
It outputs them not in time-order which causes bugs in Projections when viewing them.
@lifflander lifflander self-assigned this Sep 5, 2023
lifflander added a commit that referenced this issue Sep 7, 2023
@lifflander
#2187: trace: first fix regular user events without a note
016bb11
lifflander added a commit that referenced this issue Sep 7, 2023
@lifflander
#2187: trace: fix order of nested trace user events
452e4bd
@lifflander lifflander linked a pull request Sep 7, 2023 that will close this issue
#2187: nested trace user events output in wrong order #2188
Merged
@lifflander lifflander mentioned this issue Sep 7, 2023
Merged
thearusable pushed a commit that referenced this issue Jul 2, 2024
@lifflander @thearusable
#2187: trace: first fix regular user events without a note
9c4e363
thearusable pushed a commit that referenced this issue Jul 2, 2024
@lifflander @thearusable
#2187: trace: fix order of nested trace user events
f914c4f
thearusable added a commit that referenced this issue Jul 2, 2024
@thearusable
#2187: Redo some of the changes after resolving conflicts
b8f7e23
thearusable added a commit that referenced this issue Jul 3, 2024
@thearusable
#2187: Use TraceScopedNote instead of addUserBracketedNote(...)
2f03796
thearusable added a commit that referenced this issue Jul 5, 2024
@thearusable
#2187: Fix order of traces for addUserNotePre/Epi
d286b16
thearusable added a commit that referenced this issue Jul 5, 2024
@thearusable
#2187: Rework the bracketed user note
4d80044
thearusable added a commit that referenced this issue Jul 5, 2024
@thearusable
#2187: Use new constructor of TraceScopedNote without an empty note
5ba1f53
thearusable added a commit that referenced this issue Jul 6, 2024
@thearusable
#2187: Remove trailing whitespace
8964ad6
thearusable added a commit that referenced this issue Jul 8, 2024
@thearusable
#2187: Update TraceScopedNote to prevent tracing without user event ID
d948ae2
thearusable added a commit that referenced this issue Jul 8, 2024
@thearusable
#2187: Add tests for user tracing behavior
21480eb
thearusable added a commit that referenced this issue Jul 9, 2024
@thearusable
#2187: Fix for crash which could occur when stopping the vt
7659f4e
thearusable added a commit that referenced this issue Jul 9, 2024
@thearusable
#2187: Add checks in tests for validating end time
2e8dfc9
thearusable pushed a commit that referenced this issue Jul 10, 2024
@lifflander @thearusable
#2187: trace: first fix regular user events without a note
f4b9152
thearusable pushed a commit that referenced this issue Jul 10, 2024
@lifflander @thearusable
#2187: trace: fix order of nested trace user events
d29f7a8
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Redo some of the changes after resolving conflicts
6a1cf8f
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Use TraceScopedNote instead of addUserBracketedNote(...)
28eb2a4
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Fix order of traces for addUserNotePre/Epi
d0133d9
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Rework the bracketed user note
a7444ee
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Use new constructor of TraceScopedNote without an empty note
12591a4
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Remove trailing whitespace
a764eeb
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Update TraceScopedNote to prevent tracing without user event ID
c2445bc
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Add tests for user tracing behavior
598ef37
thearusable added a commit that referenced this issue Jul 10, 2024
@thearusable
#2187: Fix for crash which could occur when stopping the vt
bba0844
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Add additional checks in tests for validating the end time
c56a180
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Add a note to the documentation about incomplete notes
739588f
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Fix typos in trace.md
f4ced15
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Fix constant being used in TraceScopedNote
49c9c59
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Update interface for adding user note to be more clear with th…
cde125e 
…e message overriding behavior
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Remove default event id from TraceScopedNote
ddc124b
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Add missing documentation for updateNoteEndTime method
45beabf
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Use proper constant when adding a user note
0af8aab
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Fix order of the parametrs in the method for starting a user note
7076e70
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2187: Fix wrong constant being used in addUserNotePre/Epi
193f7e7
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@lifflander @cz4rs
#2187: trace: first fix regular user events without a note
b4dd4fd
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@lifflander @cz4rs
#2187: trace: fix order of nested trace user events
25e0875
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Redo some of the changes after resolving conflicts
cfa388b
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Use TraceScopedNote instead of addUserBracketedNote(...)
bd7c091
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Fix order of traces for addUserNotePre/Epi
5536b39
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Rework the bracketed user note
858de2f
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Use new constructor of TraceScopedNote without an empty note
96f9856
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Update TraceScopedNote to prevent tracing without user event ID
dddc571
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Add tests for user tracing behavior
cad15ee
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Fix for crash which could occur when stopping the vt
730c262
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Add additional checks in tests for validating the end time
9c62d6d
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Add a note to the documentation about incomplete notes
2f37c81
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Fix typos in trace.md
b4ea497
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Fix constant being used in TraceScopedNote
946cd63
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Update interface for adding user note to be more clear with th…
141ed35 
…e message overriding behavior
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Remove default event id from TraceScopedNote
b1c432f
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Add missing documentation for updateNoteEndTime method
5711264
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Use proper constant when adding a user note
bd912de
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Fix order of the parametrs in the method for starting a user note
c3ad3b8
cz4rs pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cz4rs
#2187: Fix wrong constant being used in addUserNotePre/Epi
b730afd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lifflander lifflander

@thearusable thearusable

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2187: nested trace user events output in wrong order DARMA-tasking/vt
2 participants
@lifflander @thearusable