Skip to content

Commit

Permalink
#2187: Remove default event id from TraceScopedNote
Browse files Browse the repository at this point in the history
  • Loading branch information
thearusable authored and cz4rs committed Sep 20, 2024
1 parent 141ed35 commit b1c432f
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/vt/trace/trace_user.h
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ struct TraceScopedNote final {
* \c registerEventCollective )
*/
TraceScopedNote(
std::string const& in_note, TraceEventIDType const in_event = no_trace_event
std::string const& in_note, TraceEventIDType const in_event
) : event_(in_event),
note_(in_note)
{
Expand All @@ -268,7 +268,7 @@ struct TraceScopedNote final {
* \param[in] event the user event to log (e.g., may be obtained from
* \c registerEventCollective )
*/
TraceScopedNote(TraceEventIDType const in_event = no_trace_event)
TraceScopedNote(TraceEventIDType const in_event)
: event_(in_event),
note_("")
{
Expand Down Expand Up @@ -316,10 +316,11 @@ struct TraceScopedNote final {
#else

struct TraceScopedNote final {
TraceScopedNote(std::string const&, TraceEventIDType const = no_trace_event) { }
TraceScopedNote(std::string const&, TraceEventIDType const) { }
TraceScopedNote(TraceEventIDType const) { }

void end() { }
void setNote([[maybe_unused]] std::string const& in_note) { }
void setNote(std::string const&) { }
};

struct TraceScopedEvent final {
Expand Down

0 comments on commit b1c432f

Please sign in to comment.