-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runLambda needs to explicitly return void #2091
Labels
Comments
If adding template <typename Callable, typename... Args>
decltype(auto) runLambda(Callable&& c, Args&&... args) {
start();
// Arrange a scope guard to call finish() without any sort of dynamic allocation
struct finisher {
Runnable *r;
~finisher() { r->finish(); }
};
finisher f(this);
return std::invoke(std::forward<Callable>(c), std::forward<Args>(args)...);
} |
The same warning is visible in nvcc output (#2104). |
cz4rs
added a commit
that referenced
this issue
Mar 14, 2023
cz4rs
added a commit
that referenced
this issue
Mar 15, 2023
lifflander
pushed a commit
that referenced
this issue
Mar 21, 2023
cz4rs
added a commit
that referenced
this issue
Mar 27, 2023
cz4rs
added a commit
that referenced
this issue
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
ARMIntel compiler on Gitlab CI emits this warning:/.../vt/src/vt/runnable/runnable.h(245): warning #1011: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]"
about this code from
runnable/runnable.h
:We probably just need to explicitly
return;
for the case where the lambda returns void.The text was updated successfully, but these errors were encountered: