Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GossipLB inform and decide have bugs #1279

Closed
nlslatt opened this issue Feb 22, 2021 · 1 comment · Fixed by #1348
Closed

GossipLB inform and decide have bugs #1279

nlslatt opened this issue Feb 22, 2021 · 1 comment · Fixed by #1348
Assignees
@nlslatt
Labels
1.0.0-beta.10.4.1 1.0.1 type: bug

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented Feb 22, 2021

Describe the bug
Imbalances produced by GossipLB are inferior to those predicted by LBAF due to bugs in both the inform and decide steps.

To Reproduce
Steps to reproduce the behavior:

  1. Example/test/snippet of code that fails
  2. Compiler, platform, libraries
  3. Run command: number of processors, threading options, etc.
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

  • Supercomputer or desktop [e.g., Trinity, Sierra)
  • Compiler environment [e.g., clang-3.9, gcc8]
  • Libraries [e.g., mpich-2, openmpi)
  • Commit ID or release of VT [e.g., vt-1.0.0]

Additional context
Add any other context about the problem here.
@nlslatt nlslatt self-assigned this Feb 22, 2021
nlslatt added a commit that referenced this issue Feb 22, 2021
@nlslatt
#1279: gossiplb: Use best of multiple trials
7e06966
nlslatt added a commit that referenced this issue Feb 22, 2021
@nlslatt
#1279: gossiplb: select unique nodes
e2f1288
nlslatt added a commit that referenced this issue Feb 22, 2021
@nlslatt
#1279: gossiplb: pass load instead of rank
71313d3
@lifflander lifflander mentioned this issue Feb 23, 2021
Open
nlslatt pushed a commit that referenced this issue Feb 23, 2021
@lifflander @nlslatt
#1279: gossiplb: init variable
1d52125
nlslatt added a commit that referenced this issue Mar 2, 2021
@nlslatt
#1279: gossiplb: improve debugging output
3e04f44
nlslatt added a commit that referenced this issue Mar 2, 2021
@nlslatt
#1279: gossiplb: corrected async informs
89621cb
nlslatt added a commit that referenced this issue Mar 2, 2021
@nlslatt
#1279: gossiplb: added sync informs that match lbaf
f301ba7
nlslatt added a commit that referenced this issue Mar 2, 2021
@nlslatt
#1279: gossiplb: cleanup
66e7335
nlslatt added a commit that referenced this issue Mar 2, 2021
@nlslatt
#1279: gossiplb: order objects by object id
aa48370
nlslatt added a commit that referenced this issue Mar 5, 2021
@nlslatt
#1279: gossiplb: add deterministic mode
9e5d2a4
nlslatt added a commit that referenced this issue Mar 5, 2021
@nlslatt
#1279: gossiplb: fix loads that ended up in microseconds
64ef307
nlslatt added a commit that referenced this issue Mar 5, 2021
@nlslatt
#1279: gossiplb: add object ordering options
8ff6218
nlslatt added a commit that referenced this issue Mar 5, 2021
@nlslatt
#1279: gossiplb: cleanup
bd7e72e
nlslatt added a commit that referenced this issue Mar 6, 2021
@nlslatt
#1279: gossiplb: increase precision of imbalance
2f637db
nlslatt added a commit that referenced this issue Mar 6, 2021
@nlslatt
#1279: gossiplb: add options for cmf
6af1c27
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: Use best of multiple trials
23a2469
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: select unique nodes
63cc8f1
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: pass load instead of rank
66316d5
nlslatt pushed a commit that referenced this issue Mar 8, 2021
@lifflander @nlslatt
#1279: gossiplb: init variable
9e5d896
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: improve debugging output
d64b1a7
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: corrected async informs
67af42a
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: added sync informs that match lbaf
5ec83d5
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: cleanup
5bb72b7
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: order objects by object id
60c1b69
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: add deterministic mode
b434980
nlslatt added a commit that referenced this issue Mar 8, 2021
@nlslatt
#1279: gossiplb: fix loads that ended up in microseconds
6a33e45
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: select unique nodes
23945c5
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: pass load instead of rank
b749bdd
nlslatt pushed a commit that referenced this issue Apr 9, 2021
@lifflander @nlslatt
#1279: gossiplb: init variable
5489aab
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: improve debugging output
52decfa
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: corrected async informs
82dcc74
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: added sync informs that match lbaf
66092e1
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: cleanup
5c7db6f
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: order objects by object id
f28fd97
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: add deterministic mode
c497a80
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: fix loads that ended up in microseconds
6f47e49
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: add object ordering options
e76aed3
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: cleanup
26775fe
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: increase precision of imbalance
ec4de3d
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: add options for cmf
f3f4f72
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: tune print verbosity
45ce2d5
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: clean up redundant code
0b7dbc5
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: minimize reductions when not debugging
3a168e5
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: fix bug in cmf computation
fadcc8b
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: change default options
f19ff09
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: fix missing allowed key
3e9536b
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: prevent informs from being received early
cfccd66
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: roll back to best iter
da68ac1
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: add option to target long pole load instead of avg
e4ae883
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: name barrier to prevent hang
f832796
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: cleanup
9d72dde
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: document lb args
a0a1c26
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: fix compile errors
4d38c6a
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: clean up sync round number
da2e611
nlslatt added a commit that referenced this issue Apr 9, 2021
@nlslatt
#1279: gossiplb: convert comments to doxygen
242282c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlslatt nlslatt

Labels
1.0.0-beta.10.4.1 1.0.1 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1279 gossiplb inform and decide have bugs DARMA-tasking/vt
2 participants
@PhilMiller @nlslatt