Skip to content

Commit

Permalink
#1279: gossiplb: fix compile errors
Browse files Browse the repository at this point in the history
  • Loading branch information
nlslatt committed Apr 9, 2021
1 parent a0a1c26 commit 4d38c6a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
20 changes: 17 additions & 3 deletions src/vt/vrt/collection/balance/gossiplb/gossip_msg.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,27 @@ struct RejectionStats {
int n_transfers_ = 0;
};

struct GossipRejectionStatsMsg : collective::ReduceTMsg<RejectionStats> {
static_assert(
vt::messaging::is_byte_copyable_t<RejectionStats>::value,
"Must be trivially copyable to avoid serialization."
);

struct GossipRejectionStatsMsg : NonSerialized<
collective::ReduceTMsg<RejectionStats>,
GossipRejectionStatsMsg
>
{
using MessageParentType = NonSerialized<
collective::ReduceTMsg<RejectionStats>,
GossipRejectionStatsMsg
>;

GossipRejectionStatsMsg() = default;
GossipRejectionStatsMsg(int n_rejected, int n_transfers)
: ReduceTMsg<RejectionStats>(RejectionStats(n_rejected, n_transfers))
: MessageParentType(RejectionStats(n_rejected, n_transfers))
{ }
GossipRejectionStatsMsg(RejectionStats&& rs)
: ReduceTMsg<RejectionStats>(std::move(rs))
: MessageParentType(std::move(rs))
{ }
};

Expand Down
1 change: 0 additions & 1 deletion src/vt/vrt/collection/balance/gossiplb/gossiplb.cc
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ void GossipLB::doLBStages(TimeType start_imb) {

if (rollback_ || theConfig()->vt_debug_gossiplb || (iter_ == num_iters_ - 1)) {
runInEpochCollective([=] {
using StatsMsgType = balance::NodeStatsMsg;
using ReduceOp = collective::PlusOp<balance::LoadData>;
auto cb = vt::theCB()->makeBcast<
GossipLB, StatsMsgType, &GossipLB::gossipStatsHandler
Expand Down

0 comments on commit 4d38c6a

Please sign in to comment.