Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LBAF-Viz and replace with calls to vt-tv #507

Closed
ppebay opened this issue May 15, 2024 · 0 comments · Fixed by #508
Closed

Deprecate LBAF-Viz and replace with calls to vt-tv #507

ppebay opened this issue May 15, 2024 · 0 comments · Fixed by #508
Assignees
@cwschilly
Labels
enhancement New feature or request high-priority

Comments

@ppebay
Copy link
Contributor

ppebay commented May 15, 2024 •
edited by cwschilly
Loading

LBAF-Viz code should not be deleted yet, but should return a deprecation error.

A subsequent release will remove the deprecated code.

This is related to #410

As a result of closing #503, the following is made part of the current issue:
LBAF will have to remove from its CI all of the references to visualization in the config files that are tested by the config validator.
@ppebay ppebay added enhancement New feature or request high-priority labels May 15, 2024
This was referenced May 15, 2024
Closed
Closed
cwschilly added a commit that referenced this issue May 16, 2024
@cwschilly
#507: add deprecate error to lbsVisualizer
1d384d4
@cwschilly cwschilly mentioned this issue May 16, 2024
Merged
@cwschilly cwschilly linked a pull request May 16, 2024 that will close this issue
#507: Deprecate LBAF-Viz and replace with calls to vt-tv #508
Merged
cwschilly added a commit that referenced this issue May 16, 2024
@cwschilly
#507: add test for deprecation warning
7d1a14a
cwschilly added a commit that referenced this issue May 16, 2024
@cwschilly
#507: remove all references to visualization in unit test config files
e3671bd
cwschilly added a commit that referenced this issue May 16, 2024
@cwschilly
#507: add newline
c45e439
@ppebay ppebay mentioned this issue May 17, 2024
Closed
cwschilly added a commit that referenced this issue May 17, 2024
@cwschilly
#507: remove viz params from all config files
0d560e7
cwschilly added a commit that referenced this issue May 20, 2024
@cwschilly
#507: add config file test for lbaf viz deprecation
2278265
cwschilly added a commit that referenced this issue May 21, 2024
@cwschilly
#507: add deprecate error to lbsVisualizer
5fbcdb5
cwschilly added a commit that referenced this issue May 21, 2024
@cwschilly
#507: add test for deprecation warning
b5beb72
cwschilly added a commit that referenced this issue May 21, 2024
@cwschilly
#507: remove all references to visualization in unit test config files
7957233
cwschilly added a commit that referenced this issue May 21, 2024
@cwschilly
#507: add newline
b5dc290
cwschilly added a commit that referenced this issue May 21, 2024
@cwschilly
#507: remove viz params from all config files
3d897d9
cwschilly added a commit that referenced this issue May 21, 2024
@cwschilly
#507: add config file test for lbaf viz deprecation
4238367
cwschilly added a commit that referenced this issue May 21, 2024
@cwschilly
#507: remove config file test; clean up viz deprecation
9884cb1
cwschilly added a commit that referenced this issue May 21, 2024
@cwschilly
#507: restore config test for viz deprecation
6b73cf4
cwschilly added a commit that referenced this issue May 22, 2024
@cwschilly
#507: Deprecate LBAF-Viz and replace with calls to vt-tv (#508)
ed0db06 
* #507: add deprecate error to lbsVisualizer

* #507: add test for deprecation warning

* #507: remove all references to visualization in unit test config files

* #507: add newline

* #507: remove viz params from all config files

* #507: add config file test for lbaf viz deprecation

* #507: remove config file test; clean up viz deprecation

* #507: restore config test for viz deprecation
github-actions bot pushed a commit that referenced this issue May 22, 2024
@cwschilly
#507: Deprecate LBAF-Viz and replace with calls to vt-tv (#508)
4dc879f 
* #507: add deprecate error to lbsVisualizer

* #507: add test for deprecation warning

* #507: remove all references to visualization in unit test config files

* #507: add newline

* #507: remove viz params from all config files

* #507: add config file test for lbaf viz deprecation

* #507: remove config file test; clean up viz deprecation

* #507: restore config test for viz deprecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwschilly cwschilly

Labels
enhancement New feature or request high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#507: Deprecate LBAF-Viz and replace with calls to vt-tv DARMA-tasking/LB-analysis-framework
2 participants
@ppebay @cwschilly