You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The goal of this issue is to identify those parts of the CI/CD (probably mostly in the configuration validator) that are relevant to the visualization component, in order to:
know what will have to be removed from the CI/CD once LBAF-Viz is deprecated;
hopefully be able to re-use some or all of those identified parts in vt-tv.
The text was updated successfully, but these errors were encountered:
In keeping with #507 the CI/CD of LBAF-Viz must be deprecated as well
ppebay
changed the title
Identify parts of LBAF CI/CD that are relevant to LBAF-Viz
Identify and deprecate parts of LBAF CI/CD that are relevant to LBAF-Viz
May 15, 2024
Not part of LBAF CI/CD, but the lbsConfigurationValidator.py will need to be updated as well:
Optional("visualization"): {
"x_ranks": And(
int, lambdax: x>0,
error="Should be of type 'int' and > 0"),
"y_ranks": And(
int, lambdax: x>0,
error="Should be of type 'int' and > 0"),
"z_ranks": And(
int, lambdax: x>0,
error="Should be of type 'int' and > 0"),
"object_jitter": And(
float, lambdax: abs(x) <1.0,
error="Should be of type 'float' and magnitude < 1"),
"rank_qoi": str,
"output_visualization_dir": str,
"output_visualization_file_stem": str,
Optional("object_qoi"): str,
Optional("force_continuous_object_qoi"): bool,
Optional("save_meshes"): bool},
2. Parts of LBAF CI that can be re-used with vt-tv
There is no explicit testing of LBAF viz
vt-tv can potentially draw from test_lbs_vt_data_reader.py (at least for logic for testing reading in JSON)
can also test config files with similar logic to test_configuration_validator.py
The goal of this issue is to identify those parts of the CI/CD (probably mostly in the configuration validator) that are relevant to the visualization component, in order to:
The text was updated successfully, but these errors were encountered: