Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify and deprecate parts of LBAF CI/CD that are relevant to LBAF-Viz #503

Closed
ppebay opened this issue Mar 12, 2024 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ppebay
Copy link
Contributor

ppebay commented Mar 12, 2024

The goal of this issue is to identify those parts of the CI/CD (probably mostly in the configuration validator) that are relevant to the visualization component, in order to:

  1. know what will have to be removed from the CI/CD once LBAF-Viz is deprecated;
  2. hopefully be able to re-use some or all of those identified parts in vt-tv.
@ppebay
Copy link
Contributor Author

ppebay commented May 15, 2024

In keeping with #507 the CI/CD of LBAF-Viz must be deprecated as well

@ppebay ppebay changed the title Identify parts of LBAF CI/CD that are relevant to LBAF-Viz Identify and deprecate parts of LBAF CI/CD that are relevant to LBAF-Viz May 15, 2024
@cwschilly
Copy link
Contributor

1. Identify what will be removed for LBAF CI/CD

  • Many of the config files (in config/ and tests/unit/config/ include visualization parameters.

For example:

# Specify output
output_dir: ../../output
output_file_stem: output_file
visualization:
  x_ranks: 2
  y_ranks: 2
  z_ranks: 1
  object_jitter: 0.5
  rank_qoi: None
  object_qoi: None
  force_continuous_object_qoi: true
  output_visualization_dir: ../../output
  output_visualization_file_stem: output_file
  • Not part of LBAF CI/CD, but the lbsConfigurationValidator.py will need to be updated as well:
Optional("visualization"): {
                "x_ranks": And(
                    int, lambda x: x > 0,
                    error="Should be of type 'int' and > 0"),
                "y_ranks": And(
                    int, lambda x: x > 0,
                    error="Should be of type 'int' and > 0"),
                "z_ranks": And(
                    int, lambda x: x > 0,
                    error="Should be of type 'int' and > 0"),
                "object_jitter": And(
                    float, lambda x: abs(x) < 1.0,
                    error="Should be of type 'float' and magnitude < 1"),
                "rank_qoi": str,
                "output_visualization_dir": str,
                "output_visualization_file_stem": str,
                Optional("object_qoi"): str,
                Optional("force_continuous_object_qoi"): bool,
                Optional("save_meshes"): bool},

2. Parts of LBAF CI that can be re-used with vt-tv

There is no explicit testing of LBAF viz

vt-tv can potentially draw from test_lbs_vt_data_reader.py (at least for logic for testing reading in JSON)

can also test config files with similar logic to test_configuration_validator.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants